Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix counterfactual model dropdown #2680

Closed
wants to merge 1 commit into from
Closed

Fix counterfactual model dropdown #2680

wants to merge 1 commit into from

Conversation

jameswex
Copy link
Contributor

  • Motivation for features / changes

Dropdown for model selection for counterfactual was broken on polymer2 update.

  • Technical description of changes

Fix slot="dropdown-content" to match all other dropdowns

  • Detailed steps to verify changes work correctly (as executed by you)

Test dropdown functionality in multi-model demo.

@jameswex
Copy link
Contributor Author

@tolga-b please review

@jameswex
Copy link
Contributor Author

Tolga actually has this fixed already in #2607 so closing this one, sorry.

@jameswex jameswex closed this Sep 19, 2019
@jameswex jameswex deleted the model_dropdown branch September 19, 2019 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanwlee stephanwlee stephanwlee approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jameswex @stephanwlee @googlebot