Add median stats to What-If Tool regression performance stats table #2434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tolga-b please review |
tolga-b
approved these changes
Jul 17, 2019
| function mean(data) { | ||
| const sum = data.reduce((sum, value) => { | ||
| return sum + value; | ||
| }, 0); | ||
|
|
||
| return sum / data.length; | ||
| } | ||
| function median(sortedData) { |
There was a problem hiding this comment.
It may be a style thing, but if we sorted arrays within the median function, we could get rid of some repetition in the inputs below (l3549-l3551).
| function mean(data) { | ||
| const sum = data.reduce((sum, value) => { | ||
| return sum + value; | ||
| }, 0); | ||
|
|
||
| return sum / data.length; | ||
| } | ||
| function median(sortedData) { | ||
| if (sortedData.length == 0) { |
There was a problem hiding this comment.
mean does not have this check, is it necessary there as well?
There was a problem hiding this comment.
mean will return NaN already due to its use of reduce with an initial value of 0. Since median uses indexing instead of a reduce fn, it needs the check.
stephanwlee
approved these changes
Jul 17, 2019
| @@ -5811,7 +5847,9 @@ <h2>Show similarity to selected datapoint</h2> | |||
| sorts = sorts.concat(['Accuracy']); | |||
| } else { | |||
| sorts = sorts.concat( | |||
| ['Mean error', 'Mean absolute error', 'Mean squared error']); | |||
| ['Mean error', 'Median error', 'Mean absolute error', | |||
There was a problem hiding this comment.
seems like this really should be enum.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users asked for median error stats in addition to current mean error stats
Added calculation of, and display of, median error, median absolute error, and median squared error to the regression performance table.
Ran regression demo and viewed performance stats in total and broken down into slices. Verified correct median numbers and that sorting by those new columns worked.