manager: improve error messages for exec failures #2395
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This gives users a more explicit error message for common configuration
errors, like virtualenvs with
--system-site-packages
that mix andmatch packages and binaries across environments.
Test Plan:
Automated tests cover changes to
manager.py
. For notebook changes,build the Pip package, and install it and
IPython
to a new virtualenv.From an IPython shell, run through all the cases:
wchargin-branch: manager-execfailed