Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable scrolling when added large image #2164

Merged
merged 3 commits into from
Apr 30, 2019

Conversation

Ir1d
Copy link
Contributor

@Ir1d Ir1d commented Apr 27, 2019

  • Motivation for features / changes

In my case the image is too big I suppose it's 1920x640.
image
After clicking:
image

  • Technical description of changes

I let it scroll.

  • Screenshots of UI changes

image

But it's not that visually pleasing totally.

image

  • Detailed steps to verify changes work correctly (as executed by you)

  • Alternate designs / implementations considered

I'm not sure how to make it more beautiful, but the current fix works perfectly for me. Hope it helps.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@Ir1d
Copy link
Contributor Author

Ir1d commented Apr 27, 2019

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Contributor

@stephanwlee stephanwlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@Ir1d
Copy link
Contributor Author

Ir1d commented Apr 30, 2019

btw, do you think it should be overflow: auto; instead of x/y ?

@@ -113,6 +113,7 @@
height: auto;
position: relative;
margin: 0 15px 40px 0;
overflow-y: auto;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, thanks for pointing it out, this should be overflow-x. In y-axis, the page grows infinitely so there should be no scrollbar. If I am understanding your screenshots correctly, you probably had overflow-x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants