-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable scrolling when added large image #2164
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
tensorboard/plugins/image/tf_image_dashboard/tf-image-loader.html
Outdated
Show resolved
Hide resolved
btw, do you think it should be |
@@ -113,6 +113,7 @@ | |||
height: auto; | |||
position: relative; | |||
margin: 0 15px 40px 0; | |||
overflow-y: auto; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, thanks for pointing it out, this should be overflow-x
. In y-axis, the page grows infinitely so there should be no scrollbar. If I am understanding your screenshots correctly, you probably had overflow-x
.
In my case the image is too big I suppose it's 1920x640.
After clicking:
I let it scroll.
But it's not that visually pleasing totally.
Detailed steps to verify changes work correctly (as executed by you)
Alternate designs / implementations considered
I'm not sure how to make it more beautiful, but the current fix works perfectly for me. Hope it helps.