deps: upgrade TensorFlow workspace definition #1712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Bazel 0.21.0 includes a breaking change to our transitive dependencies through TensorFlow. TensorFlow has patched its workspace file accordingly. This commit upgrades our pinned version of the TensorFlow workspace to accommodate. Issue #1710 remains open after this change, because Bazel 0.21.0 has a further breaking change that causes our tests to fail when run with the default Bazel flags (see test plan below): <bazelbuild/bazel#6648>. Test Plan: On Bazel 0.21.0, running `bazel query 'deps(//...)'` fails before this change: The value 'REPOSITORY_NAME' has been removed in favor of 'repository_name()', please use the latter (https://docs.bazel.build/versions/master/skylark/lib/native.html#repository_name). You can temporarily allow the old name by using --incompatible_package_name_is_a_function=false ERROR: Evaluation of query "deps(//tensorboard)" failed: errors were encountered while computing transitive closure …but passes after it. Also, `bazel test --incompatible_strict_action_env=false //...` still passes on nightly. The new flag is needed due to a breaking change in Bazel 0.21.0 that this commit does not address. wchargin-branch: deps-tf-workspace-20181220
nfelt
approved these changes
Dec 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Bazel 0.21.0 includes a breaking change to our transitive dependencies
through TensorFlow. TensorFlow has patched its workspace file
accordingly. This commit upgrades our pinned version of the TensorFlow
workspace to accommodate.
Issue #1710 remains open after this change, because Bazel 0.21.0 has a
further breaking change that causes our tests to fail when run with the
default Bazel flags (see test plan below):
bazelbuild/bazel#6648.
Test Plan:
On Bazel 0.21.0, running
bazel query 'deps(//...)'fails before thischange:
…but passes after it.
Also,
bazel test --incompatible_strict_action_env=false //...stillpasses on nightly. The new flag is needed due to a breaking change in
Bazel 0.21.0 that this commit does not address.
wchargin-branch: deps-tf-workspace-20181220