Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Tensorboard to protobuf 5 #6887

Closed
champialex opened this issue Aug 7, 2024 · 0 comments · Fixed by #6888
Closed

Bump Tensorboard to protobuf 5 #6887

champialex opened this issue Aug 7, 2024 · 0 comments · Fixed by #6888

Comments

@champialex
Copy link

Issue 6808 was fixed by restricting the proto version to < 5.

It would be great to allow Tensorflow to work with protobuf 5, to make it easier to install it alongside other packages.
groszewn added a commit to groszewn/tensorboard that referenced this issue Aug 7, 2024
@groszewn
Relax protobuf<5.0.0 restriction
6f41f86 
Instead of restricting protobuf<5.0.0 due to the removal to
`including_default_value_fields` kwarg in `json_format.MessageToJson`
(replaced by `always_print_fields_with_nopresence`), we can instead
detect the currently installed protobuf version and use the appropriate
kwarg.

Contributes to tensorflow#6808 and should resolve tensorflow#6887.
groszewn added a commit to groszewn/tensorboard that referenced this issue Aug 7, 2024
@groszewn
Relax protobuf<5.0.0 restriction
553f8f2 
Instead of restricting `protobuf<5.0.0` due to the removal to
`including_default_value_fields` kwarg in `json_format.MessageToJson`
(replaced by `always_print_fields_with_nopresence`), we can instead
detect the currently installed protobuf version and use the appropriate
kwarg.

Contributes to tensorflow#6808 and should resolve tensorflow#6887.
@groszewn groszewn mentioned this issue Aug 7, 2024
Merged
groszewn added a commit to groszewn/tensorboard that referenced this issue Aug 7, 2024
@groszewn
Relax protobuf<5.0.0 restriction
834efb9 
Instead of restricting `protobuf<5.0.0` due to the removal to
`including_default_value_fields` kwarg in `json_format.MessageToJson`
(replaced by `always_print_fields_with_nopresence`), we can instead
detect the currently installed protobuf version and use the appropriate
kwarg.

Contributes to tensorflow#6808 and should resolve tensorflow#6887.
groszewn added a commit to groszewn/tensorboard that referenced this issue Aug 7, 2024
@groszewn
Relax protobuf<5.0.0 restriction
de0d9c9 
Instead of restricting `protobuf<5.0.0` due to the removal to
`including_default_value_fields` kwarg in `json_format.MessageToJson`
(replaced by `always_print_fields_with_nopresence`), we can instead
detect the currently installed protobuf version and use the appropriate
kwarg.

Contributes to tensorflow#6808 and should resolve tensorflow#6887.
groszewn added a commit to groszewn/tensorboard that referenced this issue Aug 7, 2024
@groszewn
Relax protobuf<5.0.0 restriction
39460eb 
Instead of restricting `protobuf<5.0.0` due to the removal to
`including_default_value_fields` kwarg in `json_format.MessageToJson`
(replaced by `always_print_fields_with_nopresence`), we can instead
detect the currently installed protobuf version and use the appropriate
kwarg.

Contributes to tensorflow#6808 and should resolve tensorflow#6887.
groszewn added a commit to groszewn/tensorboard that referenced this issue Aug 9, 2024
@groszewn
Relax protobuf<5.0.0 restriction
118b30d 
Instead of restricting `protobuf<5.0.0` due to the removal to
`including_default_value_fields` kwarg in `json_format.MessageToJson`
(replaced by `always_print_fields_with_nopresence`), we can instead
detect the currently installed protobuf version and use the appropriate
kwarg.

Contributes to tensorflow#6808 and should resolve tensorflow#6887.
groszewn added a commit to groszewn/tensorboard that referenced this issue Aug 9, 2024
@groszewn
Relax protobuf<5.0.0 restriction
5edcb74 
Instead of restricting `protobuf<5.0.0` due to the removal to
`including_default_value_fields` kwarg in `json_format.MessageToJson`
(replaced by `always_print_fields_with_nopresence`), we can instead
detect the currently installed protobuf version and use the appropriate
kwarg.

Contributes to tensorflow#6808 and should resolve tensorflow#6887.
groszewn added a commit to groszewn/tensorboard that referenced this issue Aug 9, 2024
@groszewn
Relax protobuf<5.0.0 restriction
de4c2b1 
Instead of restricting `protobuf<5.0.0` due to the removal to
`including_default_value_fields` kwarg in `json_format.MessageToJson`
(replaced by `always_print_fields_with_nopresence`), we can instead
detect the currently installed protobuf version and use the appropriate
kwarg.

Contributes to tensorflow#6808 and should resolve tensorflow#6887.
groszewn added a commit to groszewn/tensorboard that referenced this issue Aug 9, 2024
@groszewn
Relax protobuf<5.0.0 restriction
5245f9b 
Instead of restricting `protobuf<5.0.0` due to the removal to
`including_default_value_fields` kwarg in `json_format.MessageToJson`
(replaced by `always_print_fields_with_nopresence`), we can instead
detect the currently installed protobuf version and use the appropriate
kwarg.

Contributes to tensorflow#6808 and should resolve tensorflow#6887.
groszewn added a commit to groszewn/tensorboard that referenced this issue Aug 9, 2024
@groszewn
Relax protobuf<5.0.0 restriction
d3d9271 
Instead of restricting `protobuf<5.0.0` due to the removal to
`including_default_value_fields` kwarg in `json_format.MessageToJson`
(replaced by `always_print_fields_with_nopresence`), we can instead
detect the currently installed protobuf version and use the appropriate
kwarg.

Contributes to tensorflow#6808 and should resolve tensorflow#6887.
groszewn added a commit to groszewn/tensorboard that referenced this issue Aug 13, 2024
@groszewn
Relax protobuf<5.0.0 restriction (tensorflow#6888)
9570874 
Instead of restricting `protobuf<5.0.0` due to the removal to
`including_default_value_fields` kwarg in `json_format.MessageToJson`
(replaced by `always_print_fields_with_nopresence`), we can instead
detect the currently installed protobuf version and use the appropriate
kwarg.

Contributes to tensorflow#6808 and should resolve tensorflow#6887.
groszewn added a commit that referenced this issue Aug 13, 2024
@groszewn
Relax protobuf<5.0.0 restriction (#6888)
9e6d7e8 
Instead of restricting `protobuf<5.0.0` due to the removal to
`including_default_value_fields` kwarg in `json_format.MessageToJson`
(replaced by `always_print_fields_with_nopresence`), we can instead
detect the currently installed protobuf version and use the appropriate
kwarg.

Contributes to #6808 and should resolve #6887.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Relax protobuf<5.0.0 restriction groszewn/tensorboard
1 participant
@champialex