Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image step slider shows outdated data #550

Closed
teamdandelion opened this issue Sep 21, 2017 · 1 comment
Closed

Image step slider shows outdated data #550

teamdandelion opened this issue Sep 21, 2017 · 1 comment

Comments

@teamdandelion
Copy link
Contributor

If you press "reload" in the TensorBoard UI, the image will reload but the step counter will stay the same, resulting in an inaccurate step count being displayed.

Reproduction:
Run a job that outputs image summaries at a fast rate.
Load the image tab, when a certain step is present (e.g. 1000).
Wait half a minute. Press reload. The image loader will show a new image (e.g. for step 2000). However, the slider will erroneously still display 1000. Dragging the slider to a different step and then back will cause it to correctly display 2000.

chihuahua added a commit that referenced this issue Sep 21, 2017
Previously, the text atop image loaders (displaying step and wall time)
would only depend on the step index. This was problematic because during
reloads, the array of steps changes, but the number of sampled steps
remains the same, so the text above individual images would not update.

Fixes #550.

Test plan: Run mnist_with_summaries.py:
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/examples/tutorials/mnist/mnist_with_summaries.py

Start TensorBoard pointed at
/tmp/tensorflow/mnist/logs/mnist_with_summaries, and navigate to the
image dashboard. Notice that the step updates now when TensorBoard
reloads, both during the periodic reload and during manually triggered
reloads.
@chihuahua
Copy link
Member

The audio dashboard interestingly does not exhibit this problem because _currentDatum depends on both _steps and _stepIndex.

_computeCurrentDatum(steps, stepIndex) {

chihuahua added a commit that referenced this issue Sep 21, 2017
Previously, the text atop image loaders (displaying step and wall time)
would only depend on the step index. This was problematic because during
reloads, the array of steps changes, but the number of sampled steps
remains the same, so the text above individual images would not update.

Fixes #550.

Test plan: Run mnist_with_summaries.py:
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/examples/tutorials/mnist/mnist_with_summaries.py

Start TensorBoard pointed at
/tmp/tensorflow/mnist/logs/mnist_with_summaries, and navigate to the
image dashboard. Notice that the step updates now when TensorBoard
reloads, both during the periodic reload and during manually triggered
reloads.
jart pushed a commit to jart/tensorboard that referenced this issue Sep 23, 2017
Previously, the text atop image loaders (displaying step and wall time)
would only depend on the step index. This was problematic because during
reloads, the array of steps changes, but the number of sampled steps
remains the same, so the text above individual images would not update.

Fixes tensorflow#550.

Test plan: Run mnist_with_summaries.py:
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/examples/tutorials/mnist/mnist_with_summaries.py

Start TensorBoard pointed at
/tmp/tensorflow/mnist/logs/mnist_with_summaries, and navigate to the
image dashboard. Notice that the step updates now when TensorBoard
reloads, both during the periodic reload and during manually triggered
reloads.
jart pushed a commit that referenced this issue Sep 26, 2017
Previously, the text atop image loaders (displaying step and wall time)
would only depend on the step index. This was problematic because during
reloads, the array of steps changes, but the number of sampled steps
remains the same, so the text above individual images would not update.

Fixes #550.

Test plan: Run mnist_with_summaries.py:
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/examples/tutorials/mnist/mnist_with_summaries.py

Start TensorBoard pointed at
/tmp/tensorflow/mnist/logs/mnist_with_summaries, and navigate to the
image dashboard. Notice that the step updates now when TensorBoard
reloads, both during the periodic reload and during manually triggered
reloads.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants