Skip to content

Commit

Permalink
scalars: remove unused tooltip column DOM (#3546)
Browse files Browse the repository at this point in the history
When tooltipColumns become shorter after a change, we currently do not
remove the DOM. This can lead to an awkward UX where a column in the
tooltip never updates and go stale.

This change removes the tooltip row column DOM when they are no longer
shown.

FYI: the tooltip header was properly removed before.
  • Loading branch information
stephanwlee authored Apr 24, 2020
1 parent d93c457 commit fadaf0f
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions tensorboard/components/vz_line_chart2/line-chart.ts
Original file line number Diff line number Diff line change
Expand Up @@ -704,6 +704,7 @@ namespace vz_line_chart2 {
if (col.static) return;
self.drawTooltipColumn.call(self, this, col, point);
});
columns.exit().remove();
columns
.enter()
.append('td')
Expand Down

0 comments on commit fadaf0f

Please sign in to comment.