This repository has been archived by the owner on Mar 11, 2021. It is now read-only.
update selfplay to write 5% of games to a holdout directory #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
amj
commented
Feb 5, 2018
- Changes the signature on preprocessing.make_dataset_from_selfplay to return the tf_examples instead of write a file
- sets a default holdout directory and makes the appropriate changes in rl_loop.py
- currently not an argument, nor is the amount of holdout a parameter. Should it be?
brilee
approved these changes
Feb 5, 2018
preprocessing.py
Outdated
| ''' | ||
| Returns a set of tf.Examples. |
There was a problem hiding this comment.
return an iterable of tf.Example
rl_loop.py
Outdated
| @@ -28,6 +28,7 @@ | |||
| BASE_DIR = "gs://{}".format(BUCKET_NAME) | |||
| MODELS_DIR = os.path.join(BASE_DIR, 'models') | |||
| SELFPLAY_DIR = os.path.join(BASE_DIR, 'games') | |||
There was a problem hiding this comment.
While we're rejiggering our folder naming scheme, can we rename the selfplay dir? "games" is pretty nondescriptive.
| preprocessing.make_dataset_from_selfplay(game_data, fname) | ||
| tf_examples = preprocessing.make_dataset_from_selfplay(game_data) | ||
|
|
||
| # Hold out 5% of games for evaluation. |
There was a problem hiding this comment.
gilding the lily a bit but done :)
artasparks
reviewed
Feb 5, 2018
| @@ -118,10 +118,12 @@ def evaluate( | |||
| def selfplay( | |||
| load_file: "The path to the network model files", | |||
| output_dir: "Where to write the games"="data/selfplay", | |||
| holdout_dir: "Where to write the games"="data/holdout", | |||
There was a problem hiding this comment.
is this written to local disk?
There was a problem hiding this comment.
It's written to wherever you pass it. This can be a gs:// path
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.