Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: (transaction) 🐛 fixed amount denom #219

Merged
merged 16 commits into from
Mar 1, 2022
Merged

fix: (transaction) 🐛 fixed amount denom #219

merged 16 commits into from
Mar 1, 2022

Conversation

Zfinix
Copy link
Contributor

@Zfinix Zfinix commented Feb 22, 2022 •
edited
Loading

Fixes #212

@Zfinix Zfinix self-assigned this Feb 22, 2022
@Zfinix Zfinix changed the title fix: (balance) 🐛 fixed amount denom fix: (transaction) 🐛 fixed amount denom Feb 22, 2022
@Zfinix Zfinix added bug 🐛 Something isn't working and removed 🔴 DO NOT MERGE 🔴 labels Feb 24, 2022
@Zfinix Zfinix requested review from andrzejchm and wal33d006 and removed request for andrzejchm February 25, 2022 18:09
@Zfinix
Copy link
Contributor Author

Zfinix commented Feb 25, 2022

Fixes #212
Simulator Screen Shot - iPhone 13 Pro Max - 2022-02-25 at 16 22 18

@Zfinix Zfinix requested a review from andrzejchm February 25, 2022 20:49
andrzejchm
andrzejchm suggested changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@andrzejchm andrzejchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solid work! I've left few changes proposals with explanation, if you have any questions, just drop me a message!

Makefile Outdated Show resolved Hide resolved
starport_template/lib/entities/amount.dart Outdated Show resolved Hide resolved
starport_template/lib/pages/assets_transfer_sheet.dart Outdated Show resolved Hide resolved
starport_template/lib/pages/assets_transfer_sheet.dart Outdated Show resolved Hide resolved
starport_template/lib/pages/routing_page.dart Show resolved Hide resolved
starport_template/lib/pages/sign_transaction_page.dart Outdated Show resolved Hide resolved
starport_template/lib/pages/assets_transfer_sheet.dart Outdated Show resolved Hide resolved
Zfinix and others added 2 commits February 28, 2022 10:58
@Zfinix @andrzejchm
Update Makefile
5a82877 
Co-authored-by: Andrzej Chmielewski <andrzejchm@users.noreply.github.com>
@Zfinix
fix pr issues
f9aa418
@Zfinix Zfinix requested review from andrzejchm and wal33d006 March 1, 2022 09:19
@wal33d006
Copy link
Contributor

Looks amazing! Let Andrzej have a look and we are good to go!

andrzejchm
andrzejchm approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@andrzejchm andrzejchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work!

@andrzejchm andrzejchm merged commit 76f83da into main Mar 1, 2022
@andrzejchm andrzejchm deleted the fix/transfer-denom branch March 1, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wal33d006 wal33d006 wal33d006 left review comments

@andrzejchm andrzejchm andrzejchm approved these changes

Assignees

@Zfinix Zfinix

Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change denom on the "Transferred!" page
3 participants
@Zfinix @wal33d006 @andrzejchm