Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add periodic refresh back to per-namespace worker manager #7105

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add periodic refresh back to per-namespace worker manager #7105

wants to merge 2 commits into from
+44 −27

Conversation

dnr
Copy link
Member

@dnr dnr commented Jan 17, 2025

What changed?

  • Add periodic refresh back to perNamespaceWorkerManager
  • Pass full refreshArgs to getWorkerAllocation and use ns from args
  • Rename fields in workerAllocation
  • Small optimization to building the component set + options string

Why?

  • The dynamic config subscriptions only reacted to the two settings directly used by perNamespaceWorkerManager, not the enabled/disabled settings in components.
  • getWorkerAllocation/getLocallyDesiredWorkers was reading w.ns which is technically a data race since w is not locked there.
  • The fields are not used outside the package.

How did you test it?

existing tests

@dnr dnr requested a review from lina-temporal January 17, 2025 06:28
@dnr dnr requested a review from a team as a code owner January 17, 2025 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiminc yiminc yiminc approved these changes

@lina-temporal lina-temporal Awaiting requested review from lina-temporal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnr @yiminc