Populate activitypause for activity heartbeat response #7098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdoerner
approved these changes
Jan 16, 2025
stephanos
pushed a commit
to stephanos/temporal
that referenced
this pull request
Jan 17, 2025
## What changed? <!-- Describe what has changed in this PR --> Peopagate "ActivityPaused" to the workers via "heartbeat" response, in both cases. ## Why? <!-- Tell your future self why have you made these changes --> To let long-running activity workers know that activity was paused. ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> unit tests ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> No ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) --> No
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Peopagate "ActivityPaused" to the workers via "heartbeat" response, in both cases.
Why?
To let long-running activity workers know that activity was paused.
How did you test it?
unit tests
Potential risks
No
Is hotfix candidate?
No