Return error if workflow backoff timer is not fired #7095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
approved these changes
Jan 16, 2025
bergundy
pushed a commit
that referenced
this pull request
Jan 16, 2025
## What changed? Return error from task executor if workflow back of timer is not fired. ## Why? To prevent outer layers to count no-op timers as fired. ## How did you test it? Existing unit test ## Potential risks No ## Is hotfix candidate? Yes
bergundy
pushed a commit
that referenced
this pull request
Jan 16, 2025
## What changed? Return error from task executor if workflow back of timer is not fired. ## Why? To prevent outer layers to count no-op timers as fired. ## How did you test it? Existing unit test ## Potential risks No ## Is hotfix candidate? Yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Return error from task executor if workflow back of timer is not fired.
Why?
To prevent outer layers to count no-op timers as fired.
How did you test it?
Existing unit test
Potential risks
No
Is hotfix candidate?
Yes