Implement batch update options #6894
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f/batchupdateoptions
ShahabT
reviewed
Dec 2, 2024
| return fmt.Errorf("must provide UpdateMask") | ||
| } | ||
| if override := params.UpdateOptionsParams.WorkflowExecutionOptions.VersioningOverride; override != nil { | ||
| if override.GetBehavior() == enumspb.VERSIONING_BEHAVIOR_PINNED && |
There was a problem hiding this comment.
also should enforce the behavior to be set all the time.
|
closing cuz I made the same changes rebased to main and merged it last week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Implement batch update options
Why?
So users can set/unset versioning override on batches of workflows
How did you test it?
Potential risks
Documentation
Is hotfix candidate?