Update slices.SortFunc for Go 1.21 #4706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The golang.org/x/exp module was updated to use the same function signature as Go 1.21's upcoming slices.SortFunc function. This changed the return value from a bool (less than) to an int (compare to). Update Temporal to the latest version and fix the uses. For more details about this change, see the following issue and commit: - golang/go#61374 - https://cs.opensource.google/go/x/exp/+/302865e7556b4ae5de27248ce625d443ef4ad3ed
|
|
|
Hm I thought Datadog has a CLA already. Let me ask around internally about that. |
|
Hmmm Datadog definitely has a Temporal CLA signed already. I think the problem may be that I need to open the pull request from the DataDog github account; let me see if I can work out the permissions I may need. |
yycptt
approved these changes
Jul 31, 2023
This simplifies the code from a code review suggestion. Co-authored-by: Yichao Yang <yycptt@gmail.com>
|
Re CLA: Do you want to me to open this pull request again, from the Datadog github account? I believe I can do that. This work was done as a Datadog employee, so the CLA should be signed. I just updated the branch in the hopes that the test failures were flakes. |
|
@evanj we do need to get the CLA signed in order to get this pr merged. |
xwduan
pushed a commit
that referenced
this pull request
Aug 29, 2023
<!-- Describe what has changed in this PR --> **What changed?** The golang.org/x/exp module was updated to use the same function signature as Go 1.21's upcoming slices.SortFunc function. This changed the return value from a bool (less than) to an int (compare to). Update Temporal to the latest version and fix the uses. <!-- Tell your future self why have you made these changes --> **Why?** For more details about the upstream change, see the following issue and commit: - golang/go#61374 - https://cs.opensource.google/go/x/exp/+/302865e7556b4ae5de27248ce625d443ef4ad3ed <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** I ran the tests locally on my machine. <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** Worst case I may have switched the sort order somewhere accidentally. <!-- Is this PR a hotfix candidate or require that a notification be sent to the broader community? (Yes/No) --> **Is hotfix candidate?** No --------- Co-authored-by: Yichao Yang <yycptt@gmail.com>
bergundy
pushed a commit
to bergundy/temporal
that referenced
this pull request
Oct 17, 2023
<!-- Describe what has changed in this PR --> **What changed?** The golang.org/x/exp module was updated to use the same function signature as Go 1.21's upcoming slices.SortFunc function. This changed the return value from a bool (less than) to an int (compare to). Update Temporal to the latest version and fix the uses. <!-- Tell your future self why have you made these changes --> **Why?** For more details about the upstream change, see the following issue and commit: - golang/go#61374 - https://cs.opensource.google/go/x/exp/+/302865e7556b4ae5de27248ce625d443ef4ad3ed <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** I ran the tests locally on my machine. <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** Worst case I may have switched the sort order somewhere accidentally. <!-- Is this PR a hotfix candidate or require that a notification be sent to the broader community? (Yes/No) --> **Is hotfix candidate?** No --------- Co-authored-by: Yichao Yang <yycptt@gmail.com>
Merged
alexshtin
added a commit
that referenced
this pull request
Jul 26, 2024
## What changed? Switched references from `golang.org/x/exp/slices` to the standard library package. ## Why? The stdlib `slices` package was introduced in Go 1.21 so can use it. The signature changes in #4706 was all the real lifting. ## How did you test it? Ran unit tests locally. CI for the rest. ## Potential risks None. ## Documentation n/a ## Is hotfix candidate? No. Co-authored-by: Alex Shtin <alex@temporal.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
The golang.org/x/exp module was updated to use the same function signature as Go 1.21's upcoming slices.SortFunc function. This changed the return value from a bool (less than) to an int (compare to). Update Temporal to the latest version and fix the uses.
Why?
For more details about the upstream change, see the following issue and commit:
How did you test it?
I ran the tests locally on my machine.
Potential risks
Worst case I may have switched the sort order somewhere accidentally.
Is hotfix candidate?
No