Skip to content

Commit

Permalink
Skip failing test on Windows and other minor updates
Browse files Browse the repository at this point in the history
  • Loading branch information
cretz committed Oct 17, 2024
1 parent 08b616c commit bb3485f
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build-gems.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
rubyPlatform: ["aarch64-linux", "x86_64-linux", "arm64-darwin", "x86_64-darwin", "x64-mingw-ucrt"]
steps:
- name: Checkout repository
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
submodules: recursive

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
runs-on: ${{ matrix.os }}
steps:
- name: Checkout repository
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
submodules: recursive

Expand Down
9 changes: 8 additions & 1 deletion temporalio/lib/temporalio/internal/bridge.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
# frozen_string_literal: true

# Use Ruby-version-specific Rust library if present
# Use Ruby-version-specific Rust library if present. When the gem is compiled
# via the cross-gem action, it is placed in a version specific directory. E.g.
# for the Linux gem as of this writing, there will be files at:
# * temporalio/internal/bridge/3.1/temporalio_bridge.so
# * temporalio/internal/bridge/3.2/temporalio_bridge.so
# * temporalio/internal/bridge/3.3/temporalio_bridge.so
# We fallback to just temporalio/internal/bridge/temporalio_bridge.so because
# rake compile puts it there during manual build/development.
begin
RUBY_VERSION =~ /(\d+\.\d+)/
require "temporalio/internal/bridge/#{Regexp.last_match(1)}/temporalio_bridge"
Expand Down
1 change: 1 addition & 0 deletions temporalio/test/worker_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ def test_block_failure_causes_shutdown
end

def test_can_run_with_resource_tuner
skip 'Resource tuner currently failing on Windows' if RbConfig::CONFIG['host_os'] =~ /mswin|mingw|cygwin/
worker = Temporalio::Worker.new(
client: env.client,
task_queue: "tq-#{SecureRandom.uuid}",
Expand Down

0 comments on commit bb3485f

Please sign in to comment.