Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove Python < 3.9 support (#728) #730

Merged
merged 5 commits into from
Jan 24, 2025
Merged

Conversation

ozeranskii
Copy link
Contributor

@ozeranskii ozeranskii commented Jan 14, 2025

What was changed

Bumped the minimum supported Python version from 3.8 to 3.9

  • In build.py, changed the feature from pyo3/abi3-py38 to pyo3/abi3-py39.
  • Updated references in README.md, pyproject.toml, and various dependencies to indicate the base version is now Python 3.9 and higher.

Removed code tied to older logic for macOS and Python < 3.8

  • Removed the fragment with multiprocessing.set_start_method("spawn", True) for Python versions below 3.8, since the minimum supported version is now 3.9.

Why?

Project officially transitions to supporting Python 3.9+, and the Rust binding build now uses the ABI for Python 3.9 instead of 3.8.

Checklist

  1. Closes [Feature Request] Update Ruff target version to 3.9 #728

  2. How was this tested:

  1. Any docs updates needed?

@ozeranskii ozeranskii requested a review from a team as a code owner January 14, 2025 22:49
@CLAassistant
Copy link

CLAassistant commented Jan 14, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Unsure if we want to update all dependencies (at least in this PR), though if we do, I think CI is breaking with newer type expectations.

@dandavison - thoughts?

@ozeranskii
Copy link
Contributor Author

@cretz Hi! About updating dependencies, I didn't update them purposefully, I just did poetry lock --no-update as I think you did in this commit 7af48a7#diff-f53a023eedfa3fbf2925ec7dc76eecdc954ea94b7e47065393dbad519613dc89.

can you please tell me if we should fix mypy?

@cretz
Copy link
Member

cretz commented Jan 15, 2025

I just did poetry lock --no-update

Hrmm, ok. I don't think we need to do that as part of this PR since only the ruff setting is changing in the project file. Can probably revert the lock update.

Though I am unsure why that command would have changed the lock file the way it did. The lock file has updated dependencies so I wonder if a poetry update happened.

@ozeranskii
Copy link
Contributor Author

I think you're right and it's better to rollback poetry.lock now.

@ozeranskii ozeranskii changed the title chore: remove Python < 3.9 logic and update dependencies (#728) chore: remove Python < 3.9 logic (#728) Jan 15, 2025
@ozeranskii
Copy link
Contributor Author

@cretz 708e74b done

@cretz
Copy link
Member

cretz commented Jan 15, 2025

Merged main back into your branch and running CI again, will merge when it passes

@ozeranskii
Copy link
Contributor Author

ozeranskii commented Jan 15, 2025

Merged main back into your branch and running CI again, will merge when it passes

main seems to have broken linter

@cretz
Copy link
Member

cretz commented Jan 15, 2025

Yes, it looks like the auto merge made test_replayer.py invalid format. If you would be willing to pull this branch and poe format and commit/push, that should fix it.

@ozeranskii
Copy link
Contributor Author

Yes, it looks like the auto merge made test_replayer.py invalid format. If you would be willing to pull this branch and poe format and commit/push, that should fix it.

Fixed. Running CI again, please.

@ozeranskii ozeranskii changed the title chore: remove Python < 3.9 logic (#728) chore: remove Python < 3.9 support (#728) Jan 15, 2025
@ozeranskii ozeranskii changed the title chore: remove Python < 3.9 support (#728) chore: remove Python 3.9 support (#728) Jan 15, 2025
@ozeranskii ozeranskii changed the title chore: remove Python 3.9 support (#728) chore: remove Python < 3.9 support (#728) Jan 15, 2025
@cretz
Copy link
Member

cretz commented Jan 15, 2025

The failure in CI is due to an unrelated thing, but we may have to fix it before merging this. When fixed, I'll merge in to this. Sorry for all the waiting.

@ozeranskii
Copy link
Contributor Author

The failure in CI is due to an unrelated thing, but we may have to fix it before merging this. When fixed, I'll merge in to this. Sorry for all the waiting.

ok, no problem. Thank you

@dandavison dandavison force-pushed the 728 branch 2 times, most recently from 987ceed to 47468e7 Compare January 18, 2025 01:57
@ozeranskii
Copy link
Contributor Author

@cretz Hi. Can you please tell me how things are going with this PR?

)

- Bump the minimum supported Python version from 3.8 to 3.9
- Remove macOS-specific code for Python < 3.8
- Update references in README, build.py, and poetry.lock accordingly

Closes temporalio#728
@cretz
Copy link
Member

cretz commented Jan 21, 2025

Looks like @dandavison just did some rebasing against main, re-running CI now...

Copy link
Contributor

@dandavison dandavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this work @ozeranskii.

@dandavison dandavison enabled auto-merge (squash) January 24, 2025 21:06
@dandavison dandavison merged commit 07d3567 into temporalio:main Jan 24, 2025
13 checks passed
@ozeranskii ozeranskii deleted the 728 branch January 25, 2025 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Update Ruff target version to 3.9
4 participants