-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove Python < 3.9 support (#728) #730
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Unsure if we want to update all dependencies (at least in this PR), though if we do, I think CI is breaking with newer type expectations.
@dandavison - thoughts?
@cretz Hi! About updating dependencies, I didn't update them purposefully, I just did can you please tell me if we should fix mypy? |
Hrmm, ok. I don't think we need to do that as part of this PR since only the ruff setting is changing in the project file. Can probably revert the lock update. Though I am unsure why that command would have changed the lock file the way it did. The lock file has updated dependencies so I wonder if a |
I think you're right and it's better to rollback |
Merged |
main seems to have broken linter |
Yes, it looks like the auto merge made |
Fixed. Running CI again, please. |
The failure in CI is due to an unrelated thing, but we may have to fix it before merging this. When fixed, I'll merge in to this. Sorry for all the waiting. |
ok, no problem. Thank you |
987ceed
to
47468e7
Compare
@cretz Hi. Can you please tell me how things are going with this PR? |
) - Bump the minimum supported Python version from 3.8 to 3.9 - Remove macOS-specific code for Python < 3.8 - Update references in README, build.py, and poetry.lock accordingly Closes temporalio#728
Looks like @dandavison just did some rebasing against |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this work @ozeranskii.
What was changed
Bumped the minimum supported Python version from 3.8 to 3.9
pyo3/abi3-py38
topyo3/abi3-py39
.README.md
,pyproject.toml
, and various dependencies to indicate the base version is now Python 3.9 and higher.Removed code tied to older logic for macOS and Python < 3.8
multiprocessing.set_start_method("spawn", True)
for Python versions below 3.8, since the minimum supported version is now 3.9.Why?
Project officially transitions to supporting Python 3.9+, and the Rust binding build now uses the ABI for Python 3.9 instead of 3.8.
Checklist
Closes [Feature Request] Update Ruff target version to 3.9 #728
How was this tested: