Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to Python SDK launch blog post #350

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

dandavison
Copy link
Contributor

@dandavison dandavison commented Jul 17, 2023

The blog post is essential reading for anyone interested in understanding the codebase, so I think a link from the repo README makes sense. But if it is confusing to have more links up at the top then it could also go lower down, in the "Development" section.

@dandavison dandavison requested a review from a team as a code owner July 17, 2023 21:12
@CLAassistant
Copy link

CLAassistant commented Jul 17, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@@ -33,6 +33,9 @@ The workflow implementation basically turns `async def` functions into workflows
event loop. This means task management, sleep, cancellation, etc have all been developed to seamlessly integrate with
`asyncio` concepts.

See the [blog post](https://temporal.io/blog/durable-distributed-asyncio-event-loop) introducing the Python SDK for an
informal introduction to the features and their implementation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrmm, I wonder if this would be better in the "Also see" section above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I wondered the same. I put it down here to hide it slightly because here you mention some of the implementation details, and the blog is skewed more towards people who want to understand the implementation of the SDK, rather than people who simply want to use it. I thought perhaps we were aiming for the "Also see" links to be strictly user-level material. But you decide!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is good enough. Approved, merge whenever.

@dandavison dandavison enabled auto-merge (squash) July 17, 2023 22:02
@dandavison dandavison merged commit 60b72c6 into temporalio:main Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants