-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link to Python SDK launch blog post #350
Conversation
|
@@ -33,6 +33,9 @@ The workflow implementation basically turns `async def` functions into workflows | |||
event loop. This means task management, sleep, cancellation, etc have all been developed to seamlessly integrate with | |||
`asyncio` concepts. | |||
|
|||
See the [blog post](https://temporal.io/blog/durable-distributed-asyncio-event-loop) introducing the Python SDK for an | |||
informal introduction to the features and their implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hrmm, I wonder if this would be better in the "Also see" section above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I wondered the same. I put it down here to hide it slightly because here you mention some of the implementation details, and the blog is skewed more towards people who want to understand the implementation of the SDK, rather than people who simply want to use it. I thought perhaps we were aiming for the "Also see" links to be strictly user-level material. But you decide!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is good enough. Approved, merge whenever.
The blog post is essential reading for anyone interested in understanding the codebase, so I think a link from the repo README makes sense. But if it is confusing to have more links up at the top then it could also go lower down, in the "Development" section.