Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Warn/error on invalid query use #250

Closed
cretz opened this issue Jan 12, 2023 · 0 comments · Fixed by #351
Closed

[Feature Request] Warn/error on invalid query use #250

cretz opened this issue Jan 12, 2023 · 0 comments · Fixed by #351
Labels
enhancement New feature or request

Comments

@cretz
Copy link
Member

cretz commented Jan 12, 2023

Describe the solution you'd like

  • If a query is an async def we should warn by default but allow overriding/silencing that warning
  • If a query uses workflow constructs like wait_condition we should error
  • If core is not already doing it for us, if a query does anything to create commands we should error
@cretz cretz added the enhancement New feature or request label Jan 12, 2023
cretz added a commit to cretz/temporal-sdk-python that referenced this issue Jul 18, 2023
@cretz
Disallow most workflow operations in read-only context
3ef8dc4 
Fixes temporalio#250
cretz added a commit to cretz/temporal-sdk-python that referenced this issue Jul 18, 2023
@cretz
Disallow most workflow operations in read-only context
de7b7a5 
Fixes temporalio#250
@cretz cretz mentioned this issue Jul 18, 2023
Merged
cretz added a commit that referenced this issue Jul 18, 2023
@cretz
Disallow most workflow operations in read-only context (#351)
a17c0ef 
Fixes #250
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@cretz