Job ordering updates (#789)

Renamed StartWorkflow to InitializeWorkflow Now ordering is `init workflow -> patches -> random-seed-updates -> signals/updates -> other -> queries -> evictions`
temporalio · Aug 16, 2024 · 5462522 · 5462522
1 parent e79eb11
commit 5462522
Show file tree

Hide file tree

Showing 24 changed files with 296 additions and 188 deletions.
diff --git a/core/src/core_tests/activity_tasks.rs b/core/src/core_tests/activity_tasks.rs
@@ -462,7 +462,7 @@ async fn activity_timeout_no_double_resolve() {
         WorkflowCachingPolicy::NonSticky,
         &[
             gen_assert_and_reply(
-                &job_assert!(workflow_activation_job::Variant::StartWorkflow(_)),
+                &job_assert!(workflow_activation_job::Variant::InitializeWorkflow(_)),
                 vec![ScheduleActivity {
                     seq: activity_id,
                     activity_id: activity_id.to_string(),

diff --git a/core/src/core_tests/local_activities.rs b/core/src/core_tests/local_activities.rs
@@ -636,7 +636,7 @@ async fn la_resolve_during_legacy_query_does_not_combine(#[case] impossible_quer
         assert_matches!(
             task.jobs.as_slice(),
             &[WorkflowActivationJob {
-                variant: Some(workflow_activation_job::Variant::StartWorkflow(_)),
+                variant: Some(workflow_activation_job::Variant::InitializeWorkflow(_)),
             },]
         );
         core.complete_workflow_activation(WorkflowActivationCompletion::from_cmd(
@@ -1239,7 +1239,7 @@ async fn queries_can_be_received_while_heartbeating() {
     assert_matches!(
         task.jobs.as_slice(),
         &[WorkflowActivationJob {
-            variant: Some(workflow_activation_job::Variant::StartWorkflow(_)),
+            variant: Some(workflow_activation_job::Variant::InitializeWorkflow(_)),
         },]
     );
     core.complete_workflow_activation(WorkflowActivationCompletion::from_cmd(

diff --git a/core/src/core_tests/queries.rs b/core/src/core_tests/queries.rs
@@ -474,7 +474,7 @@ async fn query_cache_miss_causes_page_fetch_dont_reply_wft_too_early(
     assert_matches!(
         task.jobs.as_slice(),
         [WorkflowActivationJob {
-            variant: Some(workflow_activation_job::Variant::StartWorkflow(_)),
+            variant: Some(workflow_activation_job::Variant::InitializeWorkflow(_)),
         }]
     );
     core.complete_workflow_activation(WorkflowActivationCompletion::from_cmd(
@@ -696,7 +696,7 @@ async fn new_query_fail() {
     assert_matches!(
         task.jobs[0],
         WorkflowActivationJob {
-            variant: Some(workflow_activation_job::Variant::StartWorkflow(_)),
+            variant: Some(workflow_activation_job::Variant::InitializeWorkflow(_)),
         }
     );
 

diff --git a/core/src/core_tests/updates.rs b/core/src/core_tests/updates.rs
@@ -46,10 +46,10 @@ async fn replay_with_empty_first_task() {
         task.jobs.as_slice(),
         [
             WorkflowActivationJob {
-                variant: Some(workflow_activation_job::Variant::DoUpdate(_)),
+                variant: Some(workflow_activation_job::Variant::InitializeWorkflow(_)),
             },
             WorkflowActivationJob {
-                variant: Some(workflow_activation_job::Variant::StartWorkflow(_)),
+                variant: Some(workflow_activation_job::Variant::DoUpdate(_)),
             },
         ]
     );

diff --git a/core/src/core_tests/workflow_cancels.rs b/core/src/core_tests/workflow_cancels.rs
@@ -58,7 +58,7 @@ async fn timer_then_cancel_req(
         NonSticky,
         &[
             gen_assert_and_reply(
-                &job_assert!(workflow_activation_job::Variant::StartWorkflow(_)),
+                &job_assert!(workflow_activation_job::Variant::InitializeWorkflow(_)),
                 vec![start_timer_cmd(timer_seq, Duration::from_secs(1))],
             ),
             gen_assert_and_reply(
@@ -84,7 +84,7 @@ async fn timer_then_cancel_req_then_timer_then_cancelled() {
         NonSticky,
         &[
             gen_assert_and_reply(
-                &job_assert!(workflow_activation_job::Variant::StartWorkflow(_)),
+                &job_assert!(workflow_activation_job::Variant::InitializeWorkflow(_)),
                 vec![start_timer_cmd(1, Duration::from_secs(1))],
             ),
             gen_assert_and_reply(
@@ -114,7 +114,7 @@ async fn immediate_cancel() {
         NonSticky,
         &[gen_assert_and_reply(
             &job_assert!(
-                workflow_activation_job::Variant::StartWorkflow(_),
+                workflow_activation_job::Variant::InitializeWorkflow(_),
                 workflow_activation_job::Variant::CancelWorkflow(_)
             ),
             vec![CancelWorkflowExecution {}.into()],