Add Signal-with-Start #111
Conversation
78e8093 to
713b8ef
Compare
| @@ -65,6 +66,7 @@ message DoSignal { | |||
| // Send an arbitrary signal | |||
| HandlerInvocation custom = 2; | |||
| } | |||
| bool with_start = 3; | |||
There was a problem hiding this comment.
I also considered adding it to ClientAction instead.
PS: How are we dealing with breaking changes; ie could I move it later or is there a backwards-compatibility guarantee?
There was a problem hiding this comment.
Breaking changes aren't a problem here
| @@ -15,6 +15,7 @@ import "temporal/api/enums/v1/workflow.proto"; | |||
| message TestInput { | |||
| WorkflowInput workflow_input = 1; | |||
| ClientSequence client_sequence = 2; | |||
| ClientAction with_start_action = 3; | |||
There was a problem hiding this comment.
I had considered using the client sequence's first item, but that seemed too surprising and messy (ie how do you represent "just start").
5906881 to
adac1d6
Compare
adac1d6 to
13cf1fe
Compare
| - name: Upload generator diff | ||
| uses: actions/upload-artifact@v4 | ||
| if: always() | ||
| with: | ||
| name: generator-diff | ||
| path: generator.diff | ||
| if-no-files-found: ignore |
There was a problem hiding this comment.
This was a suggestion I added to get the protoc results from the CI, download them and apply them locally. Managing to get the right version locally, at least on OSX, is a nightmare.
Not sure if this should/can be documented somewhere?
There was a problem hiding this comment.
Could add it to the README somewhere
| @@ -15,6 +15,7 @@ import "temporal/api/enums/v1/workflow.proto"; | |||
| message TestInput { | |||
| WorkflowInput workflow_input = 1; | |||
| ClientSequence client_sequence = 2; | |||
| ClientAction with_start_action = 3; | |||
There was a problem hiding this comment.
I think this should be a new type though. Query doesn't make sense as a with start action, for example.
loadgen/kitchen-sink-gen/src/main.rs
Outdated
| let with_start_action = if u.ratio(80, 100)? { | ||
| None | ||
| } else { | ||
| let mut signal_action: DoSignal = u.arbitrary()?; | ||
| signal_action.with_start = true; | ||
| Some(ClientAction { variant: Some(client_action::Variant::DoSignal(signal_action)) }) | ||
| }; |
There was a problem hiding this comment.
If we apply my other suggestion of using a specific WithStartClientAction type, then this can become the Arbitrary implementation for that, which fits nicely.
f6a3a64 to
9854a5d
Compare
9854a5d to
6444f10
Compare
|
@Sushisource so far I've only run it for a few seconds to make sure my change was working |
What was changed
Add Signal-with-Start to fuzzer.
Why?
First part of adding Signal-with-Start and soon Update-with-Start.
Checklist
Closes
How was this tested: