Add codec-header config (closes #753) #755
Merged
+38
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To set any header other than Authorization, the codec-header config parameter can be used.
What was changed
Added the code-header property using the same pattern as grpc-meta.
Grammatical change to description of grpc-meta (it's got punctuation when it gets formatted to a single line).
Refracted the conversion from config to
stringMapHeadersProvider
to a factory function. (Slight change to existing error message here).Why?
I needed to set the cf-access-token header on codec server requests (see #753)
Checklist
Closes [Feature Request] Allow setting custom header on codec server requests #753
How was this tested:
Have NOT tested the codec-auth parameter, although it should still work (just because I haven't got a simple way to test and hope someone else does without me having to set something specific up).
Could update list of props in this section, although this section look out of date anyway (i.e.
temporal env set -h
does not return a full list of available properties).