Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codec-header config (closes #753) #755

Merged
merged 3 commits into from
Feb 14, 2025

Conversation

EddieWhi
Copy link
Contributor

@EddieWhi EddieWhi commented Feb 13, 2025

To set any header other than Authorization, the codec-header config parameter can be used.

What was changed

Added the code-header property using the same pattern as grpc-meta.
Grammatical change to description of grpc-meta (it's got punctuation when it gets formatted to a single line).
Refracted the conversion from config to stringMapHeadersProvider to a factory function. (Slight change to existing error message here).

Why?

I needed to set the cf-access-token header on codec server requests (see #753)

Checklist

  1. Closes [Feature Request] Allow setting custom header on codec server requests #753

  2. How was this tested:

  • queried workflow history with codec server behind Cloudflare Access using the cf-access-token header.
  • checked grpc-meta still works as before.
  • checked validation of grpc-meta still works and codec-header validation works too.

Have NOT tested the codec-auth parameter, although it should still work (just because I haven't got a simple way to test and hope someone else does without me having to set something specific up).

  1. Any docs updates needed?

Could update list of props in this section, although this section look out of date anyway (i.e. temporal env set -h does not return a full list of available properties).

To set any header other than Authorization, the codec-header config parameter can be used.
@CLAassistant
Copy link

CLAassistant commented Feb 13, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, let me get another team member approval and we'll merge (could be middle of next week due to holidays).

@cretz cretz merged commit 2467e7d into temporalio:main Feb 14, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Allow setting custom header on codec server requests
4 participants