Skip to content

Commit

Permalink
Convert all proto fields to camelCase (#15)
Browse files Browse the repository at this point in the history
  • Loading branch information
alexshtin authored Apr 2, 2020
1 parent 4b15d90 commit c542794
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 9 deletions.
2 changes: 1 addition & 1 deletion common/decision.proto
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ message StartChildWorkflowExecutionDecisionAttributes {

message Decision {
enums.DecisionType decisionType = 1;
oneof Attributes {
oneof attributes {
ScheduleActivityTaskDecisionAttributes scheduleActivityTaskDecisionAttributes = 2;
StartTimerDecisionAttributes startTimerDecisionAttributes = 3;
CompleteWorkflowExecutionDecisionAttributes completeWorkflowExecutionDecisionAttributes = 4;
Expand Down
2 changes: 1 addition & 1 deletion common/history.proto
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ message HistoryEvent {
enums.EventType eventType = 3;
int64 version = 4;
int64 taskId = 5;
oneof Attributes {
oneof attributes {
WorkflowExecutionStartedEventAttributes workflowExecutionStartedEventAttributes = 6;
WorkflowExecutionCompletedEventAttributes workflowExecutionCompletedEventAttributes = 7;
WorkflowExecutionFailedEventAttributes workflowExecutionFailedEventAttributes = 8;
Expand Down
8 changes: 7 additions & 1 deletion enums/enums.proto
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,13 @@ enum DLQType {
// This is only used for internal matchingservice requests
// TaskSource is the source from which a task was produced
enum TaskSource {
Unknown = 0;
TaskSourceUnknown = 0;
TaskSourceHistory = 1; // Task produced by history service
TaskSourceDbBacklog = 2; // Task produced from matching db backlog
}

// Used in Checksum
enum ChecksumFlavor {
ChecksumFlavorUnknown = 0;
ChecksumFlavorIEEECRC32OverProto3Binary = 1;
}
12 changes: 6 additions & 6 deletions workflowservice/request_response.proto
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ message GetWorkflowExecutionHistoryRequest {
int32 maximumPageSize = 3;
bytes nextPageToken = 4;
bool waitForNewEvent = 5;
enums.HistoryEventFilterType HistoryEventFilterType = 6;
enums.HistoryEventFilterType historyEventFilterType = 6;
}

message GetWorkflowExecutionHistoryResponse {
Expand All @@ -157,7 +157,7 @@ message PollForDecisionTaskResponse {
common.History history = 8;
bytes nextPageToken = 9;
common.WorkflowQuery query = 10;
common.TaskList WorkflowExecutionTaskList = 11;
common.TaskList workflowExecutionTaskList = 11;
int64 scheduledTimestamp = 12;
int64 startedTimestamp = 13;
map<string, common.WorkflowQuery> queries = 14;
Expand Down Expand Up @@ -379,8 +379,8 @@ message ListOpenWorkflowExecutionsRequest {
string namespace = 1;
int32 maximumPageSize = 2;
bytes nextPageToken = 3;
common.StartTimeFilter StartTimeFilter = 4;
oneof Filters {
common.StartTimeFilter startTimeFilter = 4;
oneof filters {
common.WorkflowExecutionFilter executionFilter = 5;
common.WorkflowTypeFilter typeFilter = 6;
}
Expand All @@ -395,8 +395,8 @@ message ListClosedWorkflowExecutionsRequest {
string namespace = 1;
int32 maximumPageSize = 2;
bytes nextPageToken = 3;
common.StartTimeFilter StartTimeFilter = 4;
oneof Filters {
common.StartTimeFilter startTimeFilter = 4;
oneof filters {
common.WorkflowExecutionFilter executionFilter = 5;
common.WorkflowTypeFilter typeFilter = 6;
common.StatusFilter statusFilter = 7;
Expand Down

0 comments on commit c542794

Please sign in to comment.