Skip to content

Commit

Permalink
Add workflow expiration and run timestamps to execution info (#505)
Browse files Browse the repository at this point in the history
_**READ BEFORE MERGING:** All PRs require approval by both Server AND
SDK teams before merging! This is why the number of required approvals
is "2" and not "1"--two reviewers from the same team is NOT sufficient.
If your PR is not approved by someone in BOTH teams, it may be summarily
reverted._

<!-- Describe what has changed in this PR -->
**What changed?**
Add new structure -WorkflowExecutionExtendedInfo

That structure has few fields:
* execution timeout time
* run timeout time
* last reset time
* cancel requested

(the last one from temporalio/api#339)

<!-- Tell your future self why have you made these changes -->
**Why?**
Per customer request.
Execution timeout timestamp may change after workflow reset, and in this
case customers have no idea when it will fire.
WorkflowExecutionInfo is reused in other server calls, like
ListWorkflow, etc.
Because of that we either add any new field to ES, or it will be nil
which is bad user experience.

<!-- Are there any breaking changes on binary or code level? -->
**Breaking changes**
No

<!-- If this breaks the Server, please provide the Server PR to merge
right after this PR was merged. -->
**Server PR**
N/A
  • Loading branch information
ychebotarev committed Dec 18, 2024
1 parent b74f78e commit 91abcc4
Show file tree
Hide file tree
Showing 39 changed files with 5,802 additions and 5,890 deletions.
9 changes: 4 additions & 5 deletions activity/v1/message.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

61 changes: 27 additions & 34 deletions batch/v1/message.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

34 changes: 15 additions & 19 deletions cloud/account/v1/message.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 91abcc4

Please sign in to comment.