[TEST]: Improvement: Verification of switches and relations dump after WFM restarting #5742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuliiamir
commented
Oct 8, 2024
| @@ -62,6 +62,20 @@ class StormLcmSpec extends HealthCheckSpecification { | |||
| wfmManipulator = new WfmManipulator(dockerHost) | |||
| } | |||
|
|
|||
| def cleanupSpec() { | |||
There was a problem hiding this comment.
added this topology readiness verification to avoid further tests execution when the topology has not been recovered after WFM restarting (we have dump verification that can fail before topology verification)
yuliiamir
commented
Oct 8, 2024
| @@ -172,4 +184,19 @@ class StormLcmSpec extends HealthCheckSpecification { | |||
| assert northbound.getAllLinks().every {it.state == IslChangeType.DISCOVERED} | |||
| } | |||
| } | |||
|
|
|||
| private def collectRelationsDetails(List relationsDump) { | |||
There was a problem hiding this comment.
According to the old logic instead of excluding fields from validation, we collect fields that should be verified.
yuliiamir
commented
Oct 8, 2024
| @@ -82,27 +96,25 @@ class StormLcmSpec extends HealthCheckSpecification { | |||
| flows.each { flow -> flow.validateAndCollectDiscrepancies().isEmpty() } | |||
|
|
|||
| and: "Database dump" | |||
| //unstable for parallel runs even when isolated. why? | |||
There was a problem hiding this comment.
It seems like the root cause of flakiness was the 'has' relation for flow_stats .
IvanChupin
approved these changes
Oct 14, 2024
pablomuri
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.