Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for issue #2363 #2364

Merged
merged 1 commit into from
May 29, 2019
Merged

Conversation

rtretyak
Copy link
Collaborator

@rtretyak rtretyak commented May 17, 2019

related to #2363


This change is Reviewable

@rtretyak rtretyak force-pushed the functional/network_restart branch from 0d7809e to 8cb129d Compare May 17, 2019 14:23
Copy link
Collaborator

@surabujin surabujin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


services/src/functional-tests/src/main/groovy/org/openkilda/functionaltests/helpers/WfmManipulator.groovy, line 41 at r1 (raw file):

        if (wait) {
            dockerClient.waitContainer(wfmContainer.id())
            TimeUnit.SECONDS.sleep(WFM_WARMUP_SECONDS)

You can wait till container stops - because this constainer is up only when it manipulate with storm topologies. After that it stops. So this "delay" can be less than WFM_WARMUP_SECONDS.

@rtretyak
Copy link
Collaborator Author


services/src/functional-tests/src/main/groovy/org/openkilda/functionaltests/helpers/WfmManipulator.groovy, line 41 at r1 (raw file):

dockerClient.waitContainer(wfmContainer.id())

waits for container to exit. The system takes far more time to actually become stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants