Skip to content

Commit

Permalink
#4964: Add information about lacp connection status for lag ports tests
Browse files Browse the repository at this point in the history
* Changed model
  • Loading branch information
pkazlenka committed Feb 10, 2023
1 parent 05ca3fb commit 41c0cdd
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 11 deletions.
3 changes: 2 additions & 1 deletion src-python/lab-service/traffexam/kilda/traffexam/action.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,10 @@ def _encode(self, entry):
return Ether() / SlowProtocol() / lacp.LACP(actor_state=actor_state_binary)

@staticmethod
def _bool_to_byte(self, boolean):
def _bool_to_byte(boolean):
return b'1' if boolean else b'0'


class ARPPush(Abstract):
dst_ipv4 = "8.8.8.9"
eth_broadcast = "FF:FF:FF:FF:FF:FF"
Expand Down
18 changes: 9 additions & 9 deletions src-python/lab-service/traffexam/kilda/traffexam/model.py
Original file line number Diff line number Diff line change
Expand Up @@ -361,16 +361,16 @@ def __init__(self, mac_address, port_number, chassis_id, ttl, **fields):


class LACPPush(Abstract):
def __init__(self, payload, **fields):
def __init__(self, fields):
super().__init__(**fields)
self.expired = payload.expired
self.defaulted = payload.defaulted
self.distributing = payload.distributing
self.collecting = payload.collecting
self.synchronization = payload.synchronization
self.aggregation = payload.aggregation
self.lacp_timeout = payload.lacp_timeout
self.lacp_activity = payload.lacp_activity
# self.expired = payload.expired
# self.defaulted = payload.defaulted
# self.distributing = payload.distributing
# self.collecting = payload.collecting
# self.synchronization = payload.synchronization
# self.aggregation = payload.aggregation
# self.lacp_timeout = payload.lacp_timeout
# self.lacp_activity = payload.lacp_activity


class ARPPush(Abstract):
Expand Down
2 changes: 1 addition & 1 deletion src-python/lab-service/traffexam/kilda/traffexam/rest.py
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ def address_emmit_lacp_packet(idnr):
payload = {}

try:
push_entry = model.LACPPush(payload, **{})
push_entry = model.LACPPush(payload)
get_context().action.lacp_push(address.iface, push_entry)
except ValueError as e:
return bottle.HTTPError(400, 'Invalid LACP payload - {}'.format(e))
Expand Down

0 comments on commit 41c0cdd

Please sign in to comment.