Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sharp-quote function symbol #20

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

sharp-quote function symbol #20

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fce97d1
sharp-quote function symbol
MartinNowak Nov 30, 2023
a075ffd
sharp-quote function symbol
MartinNowak Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions oauth2-auto.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,9 +474,9 @@ This produces the URL variant of base 64 encoding defined in RFC 4648.

Exists because this package is compatible with Emacs 26.1, but
‘base64url-encode-string’ was only added in Emacs 27.1."
(if (fboundp 'base64url-encode-string)
(if (fboundp #'base64url-encode-string)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want to leave it as a regular quote here (since at this point we don't even know if this symbol is a function, let alone bound).

;; Use funcall to silence flycheck.
(funcall 'base64url-encode-string string no-pad)
(funcall #'base64url-encode-string string no-pad)
(let* ((enc (base64-encode-string string t))
(enc (replace-regexp-in-string "+" "-" enc))
(enc (replace-regexp-in-string "/" "_" enc)))
Expand Down