Improved Qn-Workflow

.github/workflows/notify-non-core-qn.yml

@@ -1,37 +1,39 @@
 name: Notify Core Team on Non-Core Questions
+
 on:
   issue_comment:
     types: [created]
+
 permissions:
   issues: write
   pull-requests: write
+
 jobs:
   notify_core_team:
     runs-on: ubuntu-latest
     env:
-      ALLOWED_USERNAMES: ${{ vars.ALLOWED_USERNAMES }}
-      QUESTION_KEYWORDS: ${{ vars.QUESTION_KEYWORDS }}
-      QUESTION_LABELS: ${{ vars.QUESTION_LABELS }}
-      SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
+      ALLOWED_USERNAMES: ${{ vars.ALLOWED_USERNAMES || '' }}
+      QUESTION_KEYWORDS: ${{ vars.QUESTION_KEYWORDS || '' }}
+      QUESTION_LABELS: ${{ vars.QUESTION_LABELS || '' }}
+      SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK || '' }}
+
     steps:
       - name: Check and Notify
         uses: actions/github-script@v6
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
           script: |
-            console.log('Script started');
-            const isOrgMember = (commenter, allowedUsers) => {
-              return allowedUsers.split(',').map(u => u.trim()).includes(commenter);
-            };
-            const containsQuestionKeywords = (text, keywords) => {
-              return keywords.split(',').map(k => k.trim()).some(keyword =>
+            const isOrgMember = (commenter, allowedUsers) => 
+              allowedUsers.split(',').map(u => u.trim()).includes(commenter);
+
+            const containsQuestionKeywords = (text, keywords) => 
+              keywords.split(',').map(k => k.trim()).some(keyword => 
                 text.toLowerCase().includes(keyword.toLowerCase())
               );
-            };
+
             const addLabelsToIssue = async (github, context, labelsString) => {
-              const labels = labelsString.split(',').map(label => label.trim()).filter(label => label);
+              const labels = labelsString.split(',').map(label => label.trim()).filter(Boolean);
               if (labels.length > 0) {
-                console.log('Adding labels:', labels);
                 await github.rest.issues.addLabels({
                   owner: context.repo.owner,
                   repo: context.repo.repo,
@@ -40,48 +42,46 @@ jobs:
                 });
               }
             };
-            const sendSlackNotification = async (webhook, payload) => {
+
+            const sendSlackNotification = async (webhook, commentUrl) => {
+              const payload = { commentUrl };
               const response = await fetch(webhook, {
                 method: 'POST',
                 headers: { 'Content-Type': 'application/json' },
                 body: JSON.stringify(payload)
               });
               if (!response.ok) {
-                throw new Error(`HTTP error! status: ${response.status}`);
+                throw new Error(`Slack notification failed with status: ${response.status}`);
               }
             };
+
+            const isBot = async (github, commenter) => {
+              try {
+                const { data: user } = await github.rest.users.getByUsername({ username: commenter });
+                return user.type === 'Bot';
+              } catch {
+                return false;
+              }
+            };
+
             const commenter = context.payload.comment.user.login;
-            console.log('Commenter:', commenter);
-            if (!isOrgMember(commenter, process.env.ALLOWED_USERNAMES)) {
-              const commentBody = context.payload.comment.body;
-              const sanitizedComment = commentBody
-                ?.replace(/[^\w\s?]/gi, '')
-                .toLowerCase();
-              console.log('Comment body:', sanitizedComment);
-              if (containsQuestionKeywords(sanitizedComment, process.env.QUESTION_KEYWORDS)) {
-                try {
-                  console.log('Adding labels to the issue');
-                  await addLabelsToIssue(github, context, process.env.QUESTION_LABELS);
-                  console.log('Labels added successfully');
-                  const issueUrl = `https://github.com/${context.repo.owner}/${context.repo.repo}/issues/${context.payload.issue.number}`;
-                  const issueTitle = context.payload.issue.title;
-                  const issueNumber = context.payload.issue.number;
-                  console.log('Issue URL:', issueUrl);
-                  console.log('Issue Title:', issueTitle);
-                  console.log('Issue Number:', issueNumber);
-                  const payload = {
-                    link: issueUrl,
-                    Question: commentBody,
-                    "issue-number": issueNumber,
-                    title: issueTitle,
-                    user: commenter
-                  };
-                  await sendSlackNotification(process.env.SLACK_WEBHOOK, payload);
-                  console.log('Slack notification sent successfully');
-                } catch (error) {
-                  console.error('Workflow failed:', error.message);
-                  core.setFailed(`Workflow failed: ${error.message}`);
+            const allowedUsers = process.env.ALLOWED_USERNAMES;
+            const keywords = process.env.QUESTION_KEYWORDS;
+            const labels = process.env.QUESTION_LABELS;
+            const webhook = process.env.SLACK_WEBHOOK;
+
+            if (await isBot(github, commenter)) return;
+
+            if (allowedUsers && !isOrgMember(commenter, allowedUsers)) {
+              const commentBody = context.payload.comment.body.trim();
+
+              if (!commentBody.startsWith('>') && keywords && containsQuestionKeywords(commentBody, keywords)) {
+                if (labels) {
+                  await addLabelsToIssue(github, context, labels);
+                }
+                if (webhook) {
+                  const commentUrl = context.payload.comment.html_url;
+                  await sendSlackNotification(webhook, commentUrl);
                 }
               }
             }
-            console.log('Script ended');