chore: reuse core module in all themes #4518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e996fc2 to
c099d51
Compare
JoomFX
approved these changes
Jun 21, 2023
chore(classic): correct shadow var
Revert "chore(classic): correct shadow var" This reverts commit d3c90fe.
chore(classic): correct shadow var Revert "chore(classic): correct shadow var" This reverts commit 19bdda0. chore(classic): correct shadow var chore(classic): correct shadow var
chore(classic): correct shadow var chore(classic): correct shadow var chore(classic): correct shadow var chore(classic): correct shadow var chore(classic): correct shadow var
docs: generate API
This was referenced Jul 5, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR aims to re-use the
coremodule across all themes by making it both@import-able and@use-able. This requires some moving around of variables so they are available in their respective dependents, but overall should not affect the output of the themes.Most (if not all) image differences are due to fixed input-color in the bootstrap theme affecting both text and icons, due to the usage of the correct color contrast function - this is a fix.