feat: load check config on startup #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add healthz handler * feat: add health checker component * feat: check metrics endpoint health * feat: check health of all check endpoints * test: add checker tests * test: add healthz handler tests
niklastreml
reviewed
Mar 1, 2024
lvlcn-t
commented
Mar 5, 2024
1 task
9bb963e to
a39f6b9
Compare
y-eight
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Looks fine for me.
Still it is not ideal but it is a hard decision.
@niklastreml also mention to give the user multiple options to define a startup & readiness config for the sparrow. At the moment that is overengineereed I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Partly addresses the conversation of #79 to instantly trigger the config load on sparrow startup.
Changes
I've added the initial startup config load and refactored the http loader to return the runtime config per value instead of reference to avoid sending a nil pointer through the channel.
For additional information look at the commits.
Tests done
I've provided some unit tests for the initial config load.
TODO