Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conpot docker image errors #1643

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

sarkoziadam
Copy link
Contributor

@sarkoziadam sarkoziadam commented Aug 24, 2024

Hello,

Today I tried to create my own docker container, but the conpot containers did not work, the container kept restarting with a similar error:

Traceback (most recent call last):
  File "/usr/bin/conpot", line 37, in <module>
    from conpot import protocols
  File "/usr/lib/python3.11/site-packages/conpot/protocols/__init__.py", line 28, in <module>
    from .snmp.snmp_server import SNMPServer
  File "/usr/lib/python3.11/site-packages/conpot/protocols/snmp/snmp_server.py", line 25, in <module>
    from conpot.protocols.snmp.command_responder import CommandResponder
  File "/usr/lib/python3.11/site-packages/conpot/protocols/snmp/command_responder.py", 6th line, in <module>
    from pysmi.reader import FileReader, FtpReader

The error is caused by the new pysmi release because the FtpReader function has been removed. (lextudio/pysnmp@7df1e46)
(I also tried pysmi==1.2.1, but that didn't work either.)

I have updated the conpot/dist/requirements.txt file, so it works again.

Version of pysmi set to previous release, FtpReader function has been removed from the new release
Copy link

github-actions bot commented Sep 1, 2024

This pull request has been marked as stale because it has had no activity for 7 days. If you are still working on this, please comment or it will be closed in 7 days.

@t3chn0m4g3
Copy link
Member

Thanks for taking the time to submit the PR.
Build runs fine here with git checkout 26c67d11b08a855a28e87abd186d959741f46c7f.
Have you tried a different commit from the conpot repo?

@sarkoziadam
Copy link
Contributor Author

No, I didn't try different commit from conpot, I just changed the python dependency.

@t3chn0m4g3
Copy link
Member

@sarkoziadam I did not have to change the deps, worked perfectly fine. Maybe it was just a glitch?

Thanks for the PR again, but right now, I do not think the change is necessary.

@t3chn0m4g3 t3chn0m4g3 closed this Sep 13, 2024
@t3chn0m4g3 t3chn0m4g3 reopened this Oct 16, 2024
@t3chn0m4g3
Copy link
Member

Seems my end was glitching, I could reproduce it as described.

Thanks again for taking the time to PR this!

@t3chn0m4g3 t3chn0m4g3 merged commit c9a87f9 into telekom-security:master Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants