Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix spelling in module docs #83

Merged
merged 3 commits into from
Jan 11, 2021
Merged

fix spelling in module docs #83

merged 3 commits into from
Jan 11, 2021

Conversation

rndmh3ro
Copy link
Collaborator

No description provided.

@rndmh3ro rndmh3ro added the documentation Improvements or additions to documentation label Jan 10, 2021
@rndmh3ro rndmh3ro requested a review from schurzi January 10, 2021 15:49
@codecov
Copy link

codecov bot commented Jan 10, 2021

Codecov Report

Merging #83 (6cffecd) into master (ed6b034) will decrease coverage by 0.43%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
- Coverage   93.71%   93.27%   -0.44%     
==========================================
  Files          17       17              
  Lines         493      684     +191     
  Branches       47       72      +25     
==========================================
+ Hits          462      638     +176     
  Misses          9        9              
- Partials       22       37      +15     
Impacted Files Coverage Δ
plugins/modules/icinga_command.py 94.11% <ø> (-1.54%) ⬇️
plugins/modules/icinga_command_template.py 93.93% <ø> (-1.52%) ⬇️
plugins/modules/icinga_endpoint.py 94.28% <ø> (-1.37%) ⬇️
plugins/modules/icinga_host.py 93.54% <ø> (-1.69%) ⬇️
plugins/modules/icinga_host_template.py 93.33% <ø> (-1.67%) ⬇️
plugins/modules/icinga_hostgroup.py 93.54% <ø> (-1.46%) ⬇️
plugins/modules/icinga_notification.py 93.93% <ø> (-1.30%) ⬇️
plugins/modules/icinga_notification_template.py 93.75% <ø> (-1.25%) ⬇️
plugins/modules/icinga_service.py 93.75% <ø> (+0.89%) ⬆️
plugins/modules/icinga_service_apply.py 96.22% <ø> (+1.48%) ⬆️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed6b034...6cffecd. Read the comment docs.

Copy link
Contributor

@schurzi schurzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inconsistent use of - as I understand they should be everywhere, when there are multiple lines/sentences?

@rndmh3ro
Copy link
Collaborator Author

inconsistent use of - as I understand they should be everywhere, when there are multiple lines/sentences?

I fixed hopefully all inconsistences. Can you please re-check?

@rndmh3ro rndmh3ro merged commit ccc15e8 into master Jan 11, 2021
@rndmh3ro rndmh3ro deleted the fix_spelling branch January 11, 2021 10:57
@rndmh3ro rndmh3ro added the bug Something isn't working label Jan 11, 2021
@@ -30,7 +30,7 @@
DOCUMENTATION = """
---
module: icinga_command_template
short_description: Manage command templates in Icinga2
short_description: Manage command templates in Icinga2.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The short description is the only thing that should not end in a period.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll fix that.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felixfontein is that something that you have to know or is it picked up by linting/sanity/etc ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmsimard that's something you have to know, or use @Andersson007's checking tool for.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, TIL: https://github.com/Andersson007/ansible_reviewer

Is this tool something I can rely on that it finds things that are worth changing?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rndmh3ro to my knowledge the tool is not used in an official capacity right now but we are, generally speaking, looking at opportunities to automate these kind of checks in order to make it easier for collection maintainers to test and monitor for policy and best practices compliance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants