-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix spelling in module docs #83
Conversation
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
==========================================
- Coverage 93.71% 93.27% -0.44%
==========================================
Files 17 17
Lines 493 684 +191
Branches 47 72 +25
==========================================
+ Hits 462 638 +176
Misses 9 9
- Partials 22 37 +15
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inconsistent use of -
as I understand they should be everywhere, when there are multiple lines/sentences?
I fixed hopefully all inconsistences. Can you please re-check? |
@@ -30,7 +30,7 @@ | |||
DOCUMENTATION = """ | |||
--- | |||
module: icinga_command_template | |||
short_description: Manage command templates in Icinga2 | |||
short_description: Manage command templates in Icinga2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The short description is the only thing that should not end in a period.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'll fix that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@felixfontein is that something that you have to know or is it picked up by linting/sanity/etc ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmsimard that's something you have to know, or use @Andersson007's checking tool for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, TIL: https://github.com/Andersson007/ansible_reviewer
Is this tool something I can rely on that it finds things that are worth changing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rndmh3ro to my knowledge the tool is not used in an official capacity right now but we are, generally speaking, looking at opportunities to automate these kind of checks in order to make it easier for collection maintainers to test and monitor for policy and best practices compliance.
No description provided.