Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve coverage of new service module #51

Merged
merged 2 commits into from
Oct 26, 2020
Merged

improve coverage of new service module #51

merged 2 commits into from
Oct 26, 2020

Conversation

rndmh3ro
Copy link
Collaborator

No description provided.

@rndmh3ro rndmh3ro requested a review from schurzi October 22, 2020 07:54
@codecov
Copy link

codecov bot commented Oct 22, 2020

Codecov Report

Merging #51 into master will increase coverage by 0.83%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
+ Coverage   92.30%   93.14%   +0.83%     
==========================================
  Files          15       15              
  Lines         455      452       -3     
  Branches       45       45              
==========================================
+ Hits          420      421       +1     
+ Misses         14       10       -4     
  Partials       21       21              
Impacted Files Coverage Δ
plugins/modules/icinga_service_apply.py 94.73% <ø> (ø)
plugins/modules/icinga_service.py 92.85% <100.00%> (+6.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d503cf...77b6bed. Read the comment docs.

@rndmh3ro rndmh3ro merged commit 0f315aa into master Oct 26, 2020
@rndmh3ro rndmh3ro deleted the improve_coverage branch October 26, 2020 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants