Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider true/false in docs for boolean #203

Merged
merged 8 commits into from
Mar 7, 2023
Merged

Consider true/false in docs for boolean #203

merged 8 commits into from
Mar 7, 2023

Conversation

Nemental
Copy link
Contributor

@Nemental Nemental commented Mar 6, 2023

Replace yes/no with true/false in docs.
fixes #202

@Nemental Nemental changed the title Consider true/false in docs for boolean Draft: Consider true/false in docs for boolean Mar 6, 2023
@Nemental Nemental marked this pull request as draft March 6, 2023 13:48
@Nemental Nemental marked this pull request as ready for review March 6, 2023 14:05
@Nemental
Copy link
Contributor Author

Nemental commented Mar 6, 2023

@Nemental Nemental changed the title Draft: Consider true/false in docs for boolean Consider true/false in docs for boolean Mar 6, 2023
@rndmh3ro
Copy link
Collaborator

rndmh3ro commented Mar 7, 2023

Thanks for your PR. Unfortunately the documentation gets automatically created automatically from the DOCUMENTATION and EXAMPLES in the plugins, e.g. this: https://github.com/T-Systems-MMS/ansible-collection-icinga-director/blob/master/plugins/modules/icinga_command.py#L66

So you'd need to change all files in the plugins-folder and in the inventory-plugin: https://github.com/T-Systems-MMS/ansible-collection-icinga-director/blob/master/plugins/inventory/icinga_director_inventory.py

You then have to run the update-script manually (https://github.com/T-Systems-MMS/ansible-collection-icinga-director/blob/master/CONTRIBUTING.md#updating-the-tests-and-examples) but I can also do this afterwards.

Do you want tackle this?

I'm unsure about the column Required in

We can keep this as it is.

@rndmh3ro rndmh3ro added the patch label Mar 7, 2023
@rndmh3ro rndmh3ro merged commit cc19cc9 into telekom-mms:master Mar 7, 2023
@rndmh3ro
Copy link
Collaborator

rndmh3ro commented Mar 7, 2023

Thank you!

@Nemental Nemental deleted the docs/boolean branch March 7, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider using true/false for all booleans in docs
2 participants