Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add galaxy.yml to yamllinting #191

Merged
merged 1 commit into from
Nov 15, 2022
Merged

add galaxy.yml to yamllinting #191

merged 1 commit into from
Nov 15, 2022

Conversation

rndmh3ro
Copy link
Collaborator

after changeing the var-substitute action, we can now yamllint the galaxy.yml

@rndmh3ro rndmh3ro force-pushed the linting branch 2 times, most recently from a99d9c1 to ea966f0 Compare November 14, 2022 16:35
@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #191 (b75426d) into master (d7922b4) will increase coverage by 3.47%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
+ Coverage   93.80%   97.27%   +3.47%     
==========================================
  Files          40       41       +1     
  Lines        1097     1101       +4     
  Branches      172      172              
==========================================
+ Hits         1029     1071      +42     
  Misses         16       16              
+ Partials       52       14      -38     
Flag Coverage Δ
integration 93.80% <ø> (ø)
sanity 53.31% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/doc_fragments/common_options.py 100.00% <0.00%> (ø)
plugins/modules/icinga_service.py 93.33% <0.00%> (+1.33%) ⬆️
plugins/modules/icinga_service_apply.py 97.72% <0.00%> (+2.27%) ⬆️
plugins/modules/icinga_scheduled_downtime.py 94.44% <0.00%> (+2.77%) ⬆️
plugins/modules/icinga_host.py 92.85% <0.00%> (+3.57%) ⬆️
plugins/modules/icinga_command.py 100.00% <0.00%> (+3.57%) ⬆️
plugins/modules/icinga_notification.py 92.85% <0.00%> (+3.57%) ⬆️
plugins/modules/icinga_command_template.py 100.00% <0.00%> (+3.57%) ⬆️
plugins/modules/icinga_user.py 100.00% <0.00%> (+3.84%) ⬆️
plugins/modules/icinga_zone.py 100.00% <0.00%> (+3.84%) ⬆️
... and 29 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rndmh3ro rndmh3ro force-pushed the linting branch 4 times, most recently from a0515dc to b75426d Compare November 14, 2022 17:02
ansible-test sanity uses yamllint and pylint, so we need no extra step.

ansible-lint has a separate action so we can fully remove tox and rely on the CI.

fix all erros in linting
@rndmh3ro rndmh3ro marked this pull request as ready for review November 14, 2022 17:06
@rndmh3ro rndmh3ro requested a review from schurzi November 15, 2022 08:26
@schurzi schurzi merged commit 54e3c41 into master Nov 15, 2022
@schurzi schurzi deleted the linting branch November 15, 2022 09:02
rndmh3ro pushed a commit that referenced this pull request Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants