Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower bar for contributions: add generated preview links to website PRs #331

Closed
abrennan89 opened this issue Dec 3, 2021 · 7 comments
Closed
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@abrennan89
Copy link

Feature request

The bar seems very high for simple docs contributions: https://github.com/tektoncd/website/blob/main/DEVELOPMENT.md

I am pretty sure I have all of these tools installed, but to make sure I would need to go and find verification steps for each, since these aren't listed. I'd also need to go to each individual site to get install instructions if I didn't have any of the tools, rather than just a Getting Started type page that provides steps, or maybe a setup script.

There are also no minimum versions listed, so it's not clear if I would need to update things like Hugo where I may have an older version.

Rather than needing to do all this, it would be nice if I could just open a PR that generates a link to a netlify preview automatically.

Use case

As a new contributor to Tekton, I would like to easily be able to open a docs preview, without having to spend a lot of time setting it up locally.

Examples

@abrennan89 abrennan89 added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 3, 2021
@AlanGreene
Copy link
Member

AlanGreene commented Dec 3, 2021

Thanks for raising this issue @abrennan89, I agree that we could make the instructions clearer and the process more straightforward to help folks get up and running quickly. Having a handy reference of any prereqs (including versions) in one place would be a start.

We do have Netlify preview links on PRs already, see for example this PR: #298

image

Clicking the 'Details' link brings you to the Netlify preview deployment, for that PR it's https://deploy-preview-298--tekton.netlify.app/

We used to have instructions for running locally using netlify dev but I'm not sure why that was removed, maybe we could revisit that.

@afrittoli
Copy link
Member

Thanks for raising this issue @abrennan89, I agree that we could make the instructions clearer and the process more straightforward to help folks get up and running quickly. Having a handy reference of any prereqs (including versions) in one place would be a start.

We do have Netlify preview links on PRs already, see for example this PR: #298

image

Clicking the 'Details' link brings you to the Netlify preview deployment, for that PR it's https://deploy-preview-298--tekton.netlify.app/

We used to have instructions for running locally using netlify dev but I'm not sure why that was removed, maybe we could revisit that.

I think the instructions are still there? Maybe we could push them up in the page and move the "docker compose" approach lower in the list.

@tekton-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 3, 2022
@tekton-robot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 2, 2022
@geriom
Copy link
Contributor

geriom commented Apr 19, 2022

We have a doc that covers how to run the site locally either installing the necessary dependencies or using docker compose. https://tekton.dev/docs/contribute/run-locally/

Maybe we can simplify the contributions landing page to make it more succinct and add clear instructions on how to preview your PR.

@tekton-robot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

5 participants