-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lower bar for contributions: add generated preview links to website PRs #331
Comments
Thanks for raising this issue @abrennan89, I agree that we could make the instructions clearer and the process more straightforward to help folks get up and running quickly. Having a handy reference of any prereqs (including versions) in one place would be a start. We do have Netlify preview links on PRs already, see for example this PR: #298 Clicking the 'Details' link brings you to the Netlify preview deployment, for that PR it's https://deploy-preview-298--tekton.netlify.app/ We used to have instructions for running locally using |
I think the instructions are still there? Maybe we could push them up in the page and move the "docker compose" approach lower in the list. |
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
Stale issues rot after 30d of inactivity. /lifecycle rotten Send feedback to tektoncd/plumbing. |
We have a doc that covers how to run the site locally either installing the necessary dependencies or using docker compose. https://tekton.dev/docs/contribute/run-locally/ Maybe we can simplify the contributions landing page to make it more succinct and add clear instructions on how to preview your PR. |
Rotten issues close after 30d of inactivity. /close Send feedback to tektoncd/plumbing. |
@tekton-robot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Feature request
The bar seems very high for simple docs contributions: https://github.com/tektoncd/website/blob/main/DEVELOPMENT.md
I am pretty sure I have all of these tools installed, but to make sure I would need to go and find verification steps for each, since these aren't listed. I'd also need to go to each individual site to get install instructions if I didn't have any of the tools, rather than just a Getting Started type page that provides steps, or maybe a setup script.
There are also no minimum versions listed, so it's not clear if I would need to update things like Hugo where I may have an older version.
Rather than needing to do all this, it would be nice if I could just open a PR that generates a link to a netlify preview automatically.
Use case
As a new contributor to Tekton, I would like to easily be able to open a docs preview, without having to spend a lot of time setting it up locally.
Examples
The text was updated successfully, but these errors were encountered: