-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump knative/pkg to 1.11 #1630
Bump knative/pkg to 1.11 #1630
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2a0643f
to
c1eb2e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@savitaashture We shouldn't update knative directly. We should only bump the pipeline and it will bump the knative.
/hold
Elaborating that: Doing this can cause a potential mismatch for the minimum version of k8s needed between Similarly, we never update the k8s API in |
c1eb2e2
to
0625e1c
Compare
I think with this update both pipeline and Triggers will have kubernetes version as 1.25. |
Right bumping to 0.50.1 will bump knative version to https://github.com/tektoncd/pipeline/blob/release-v0.50.x/go.mod#L37 But i referred @vdemeester PR tektoncd/pipeline#6975 related to knative pkg issue |
So I think we can close this? |
@savitaashture: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Yes |
Changes
Bump knative/pkg to the latest, 1.11
This also updates the min kubernetes version to 1.25.
Bumped knative pkg version as part of this issue #1628
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes