Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump knative/pkg to 1.11 #1630

Closed

Conversation

savitaashture
Copy link
Contributor

@savitaashture savitaashture commented Aug 17, 2023

Changes

Bump knative/pkg to the latest, 1.11

This also updates the min kubernetes version to 1.25.

Bumped knative pkg version as part of this issue #1628

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@savitaashture savitaashture requested review from khrm and dibyom August 17, 2023 07:14
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Aug 17, 2023
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from savitaashture after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 17, 2023
@savitaashture savitaashture force-pushed the bump_knative_pkg_1.11 branch from 2a0643f to c1eb2e2 Compare August 17, 2023 07:17
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@savitaashture We shouldn't update knative directly. We should only bump the pipeline and it will bump the knative.
/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2023
@khrm
Copy link
Contributor

khrm commented Aug 17, 2023

Elaborating that:

Doing this can cause a potential mismatch for the minimum version of k8s needed between Pipelines and Triggers.

Similarly, we never update the k8s API in Pipelines. They come from Knative.

@savitaashture savitaashture force-pushed the bump_knative_pkg_1.11 branch from c1eb2e2 to 0625e1c Compare August 17, 2023 08:28
@savitaashture
Copy link
Contributor Author

Doing this can cause a potential mismatch for the minimum version of k8s needed between Pipelines and Triggers.

I think with this update both pipeline and Triggers will have kubernetes version as 1.25.

@savitaashture
Copy link
Contributor Author

@savitaashture We shouldn't update knative directly. We should only bump the pipeline and it will bump the knative.

Right bumping to 0.50.1 will bump knative version to https://github.com/tektoncd/pipeline/blob/release-v0.50.x/go.mod#L37

But i referred @vdemeester PR tektoncd/pipeline#6975 related to knative pkg issue

@khrm
Copy link
Contributor

khrm commented Aug 17, 2023

Yes. In this case, doing this will cause the Triggers min k8s version to be 1.25 which is higher than Pipelines v0.50.

BTW, #1628 is resolved by c366270 which will be shipped in the v0.25 release. That's why I assigned you.

@khrm
Copy link
Contributor

khrm commented Aug 17, 2023

So I think we can close this?

@tekton-robot
Copy link

@savitaashture: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-triggers-build-tests 0625e1c link true /test pull-tekton-triggers-build-tests
pull-tekton-triggers-unit-tests 0625e1c link true /test tekton-triggers-unit-tests
pull-tekton-triggers-integration-tests 0625e1c link true /test pull-tekton-triggers-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@savitaashture
Copy link
Contributor Author

So I think we can close this?

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/misc Categorizes issue or PR as a miscellaneuous one. release-note-none Denotes a PR that doesnt merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants