Update to go 1.17.8 #1340
Merged
Update to go 1.17.8 #1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ahh, looks like I'll have to split this into two -
|
Looks like we need to change something else too |
2 tasks
|
/test pull-tekton-triggers-build-tests |
|
/test pull-tekton-triggers-go-coverage |
e48dcb1 to
c4e90cf
Compare
As part of this, I also ran `go fmt -s -w cmd/ pkg/ test/ tekton/ hack/` to fix the build tags and then ran `./hack/update-codegen.sh` to regenerate the code. I also had to run `go mod tidy` and `go mod vendor` to fix up some inconsistent vendoring. Fixes tektoncd#1335 Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
|
Should be ready for a review now @khrm @savitaashture |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khrm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
As part of this, I also ran
go fmt -s -w cmd/ pkg/ test/ tekton/to fix thebuild tags and then ran
./hack/update-codegen.shto regenerate the code.Fixes #1335
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes