Add a RegisterInterceptor helper function #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following is the coverage report on the affected files.
|
This makes it a lot easier to write custom interceptors while utilizing the rest of the server helpers that we have created for the packaged core interceptors. Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
|
The following is the coverage report on the affected files.
|
2 tasks
savitaashture
approved these changes
Dec 16, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: savitaashture The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This makes it a lot easier to write custom interceptors while utilizing the
rest of the server helpers that we have created for the packaged core
interceptors.
(Since the interceptors field within
Serveris not exported, it becomes impossible to use the server code for interceptors not written within the Trigger source tree)This should help a lot in the process of migrating the dogfooding interceptors in https://github.com/tektoncd/plumbing/tree/main/tekton/ci/interceptors to use the ClusterInterceptor CRD
/cc @afrittoli
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes