-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch the secret in only one function #1278
Conversation
The following is the coverage report on the affected files.
|
Interceptors all fetch the secret the same way. A util function exists for this purpose `interceptors.GetSecretToken`. Let's use it for all implementations. http.Request is always nil when calling this function. It's something to fix in the future.
When it's impossible to get the secret token, return FailedPrecondition error code like GitHub implementation.
21cbdd0
to
ec33b0a
Compare
The following is the coverage report on the affected files.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: savitaashture The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm Thank you for the cleanup! /kind cleanup |
Changes
Interceptors all fetch the secret the same way. A util function exists
for this purpose
interceptors.GetSecretToken
. Let's use it for allimplementations.
http.Request is always nil when calling this function. It's something to
fix in the future.
With this single place where the code asks for secret, we can add a
good cache.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes