Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support creating v1beta1 Pipeline resources #481

Closed
dibyom opened this issue Mar 13, 2020 · 3 comments · Fixed by #490
Closed

Support creating v1beta1 Pipeline resources #481

dibyom opened this issue Mar 13, 2020 · 3 comments · Fixed by #490
Assignees
@dibyom
Labels
area/api Indicates an issue or PR that deals with the API. kind/feature Categorizes issue or PR as related to a new feature.
Milestone
Triggers v0.4.0

Comments

@dibyom
Copy link
Member

dibyom commented Mar 13, 2020 •
edited
Loading

Expected Behavior

Triggers should be able to create both v1alpha1 and v1beta1 Tekton resources

Actual Behavior

Triggers can only create both v1alpha1 and v1beta1 Tekton resources

Steps to Reproduce the Problem

  1. Use a TriggerTemplate with a v1beta1 Tekton API

Additional Info

See: #469 (comment)
@dibyom dibyom added this to the Triggers v0.4.0 milestone Mar 13, 2020
@dibyom dibyom mentioned this issue Mar 13, 2020
Merged
3 tasks
@bobcatfish
Copy link
Collaborator

Couple places i noticed to update:

@vdemeester vdemeester changed the title Support creatiing v1beta1 Pipeline resources Support creating v1beta1 Pipeline resources Mar 16, 2020
@vdemeester
Copy link
Member

/kind feature
/area api

@tekton-robot tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. area/api Indicates an issue or PR that deals with the API. labels Mar 16, 2020
@dibyom
Copy link
Member Author

dibyom commented Mar 18, 2020

/assign

dibyom added a commit to dibyom/triggers that referenced this issue Mar 19, 2020
@dibyom
Allow creating v1beta1 resources
3ac7278 
Fixes tektoncd#481

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
@dibyom dibyom mentioned this issue Mar 19, 2020
Merged
3 tasks
dibyom added a commit to dibyom/triggers that referenced this issue Mar 20, 2020
@dibyom
Allow creating v1beta1 resources
e49752c 
Fixes tektoncd#481

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
dibyom added a commit to dibyom/triggers that referenced this issue Mar 23, 2020
@dibyom
Allow creating v1beta1 resources
d2409ef 
- Update examples to use v1beta1 by default.
- Add an explicit v1alpha1 example.
- Use v1beta1 Pipeline types for Params and tests.

Fixes tektoncd#481

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
dibyom added a commit to dibyom/triggers that referenced this issue Mar 23, 2020
@dibyom
Allow creating v1beta1 resources
3814970 
- Update examples to use v1beta1 by default.
- Add an explicit v1alpha1 example.
- Use v1beta1 Pipeline types for Params and tests.

Fixes tektoncd#481

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
dibyom added a commit to dibyom/triggers that referenced this issue Mar 24, 2020
@dibyom
Allow creating v1beta1 resources
2bdfd18 
- Update examples to use v1beta1 by default.
- Add an explicit v1alpha1 example.
- Use v1beta1 Pipeline types for Params and tests.

Fixes tektoncd#481

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
tekton-robot pushed a commit that referenced this issue Mar 24, 2020
@dibyom @tekton-robot
Allow creating v1beta1 resources
28e6565 
- Update examples to use v1beta1 by default.
- Add an explicit v1alpha1 example.
- Use v1beta1 Pipeline types for Params and tests.

Fixes #481

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dibyom dibyom

Labels
area/api Indicates an issue or PR that deals with the API. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
Triggers v0.4.0
Development

Successfully merging a pull request may close this issue.

Allow creating v1beta1 resources dibyom/triggers
4 participants
@vdemeester @bobcatfish @dibyom @tekton-robot