Clean up sink_test.go #394
Assignees
Labels
area/testing
Issues or PRs related to testing
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Comments
3 tasks
|
/kind cleanup |
|
/area testing |
|
/assign |
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Feb 18, 2020
This commit refactors sink_test: 1. Common setup/comparison extracted to helper methods 2. Removes some redundant params from the test resources 3. Remove the test that checks that we respond in 1s or less. Since we are using fake clients in these examples, this test is not as useful as it being in an e2e test. Part of tektoncd#394
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Feb 18, 2020
This commit refactors sink_test: 1. Common setup/comparison extracted to helper methods 2. Removes some redundant params from the test resources 3. Remove the test that checks that we respond in 1s or less. Since we are using fake clients in these examples, this test is not as useful as it being in an e2e test. Part of tektoncd#394 Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Feb 18, 2020
This commit refactors sink_test: 1. Common setup/comparison extracted to helper methods 2. Removes some redundant params from the test resources 3. Remove the test that checks that we respond in 1s or less. Since we are using fake clients in these examples, this test is not as useful as it being in an e2e test. Part of tektoncd#394 Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Feb 28, 2020
This commit refactors sink_test: 1. Common setup/comparison extracted to helper methods 2. Removes some redundant params from the test resources 3. Remove the test that checks that we respond in 1s or less. Since we are using fake clients in these examples, this test is not as useful as it being in an e2e test. Part of tektoncd#394 Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Feb 28, 2020
This commit refactors sink_test: 1. Common setup/comparison extracted to helper methods 2. Removes some redundant params from the test resources 3. Remove the test that checks that we respond in 1s or less. Since we are using fake clients in these examples, this test is not as useful as it being in an e2e test. Part of tektoncd#394 Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
tekton-robot
pushed a commit
that referenced
this issue
Mar 2, 2020
This commit refactors sink_test: 1. Common setup/comparison extracted to helper methods 2. Removes some redundant params from the test resources 3. Remove the test that checks that we respond in 1s or less. Since we are using fake clients in these examples, this test is not as useful as it being in an e2e test. Part of #394 Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
|
#413 fixed most of this -- most setup is now abstracted out into helper functions. Table driven tests will be a bit harder here given the variety of things were are asserting. |
|
@dibyom: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The sink_test.go file has a lot of messy tests with repeated code (especially for the
HandleEvent()function). It's difficult to write clean tests for this file, because it's pretty high-level. However, I think that we can clean up some of the code, and hopefully use some table driven tests to abstract away some of the testing logic.The text was updated successfully, but these errors were encountered: