Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninstalling Triggers can potentially uninstall Pipelines as well #262

Closed
dibyom opened this issue Dec 10, 2019 · 2 comments · Fixed by #267
Closed

Uninstalling Triggers can potentially uninstall Pipelines as well #262

dibyom opened this issue Dec 10, 2019 · 2 comments · Fixed by #267
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@dibyom
Copy link
Member

dibyom commented Dec 10, 2019

Expected Behavior

Triggers should not be responsible for creating/deleting the tekton-pipelines namespace since installing pipelines is a pre-requisite.

Actual Behavior

Reported by @AlanGreene on Slack:

Hi folks, quick question regarding install and uninstall of triggers. Is it known / expected that removing triggers (via. kubectl delete --filename https://storage.googleapis.com/tekton-releases/triggers/latest/release.yaml) removes the tekton-pipelines namespace? For me at least this was unexpected and meant I had to reinstall other projects in that namespace. Since pipeline is a pre-req, I wouldn’t have expected the triggers project to be responsible for laying down the tekton-pipelines namespace and thus including it in its cleanup. Is removing https://github.com/tektoncd/triggers/blob/master/config/100-namespace.yaml something we could consider?

Steps to Reproduce the Problem

  1. kubectl delete --filename https://storage.googleapis.com/tekton-releases/triggers/latest/release.yaml

Additional Info

@dibyom dibyom added the kind/bug Categorizes issue or PR as related to a bug. label Dec 10, 2019
@ncskier
Copy link
Member

ncskier commented Dec 11, 2019

Are we happy running everything under the tekton-pipelines namespace, or should we use our own namespace like tekton-triggers?

Thoughts @dibyom @wlynch ?

wlynch added a commit to wlynch/triggers that referenced this issue Dec 11, 2019
This makes it safe to remove triggers from a cluster without impacting
the shared pipelines namespace.

Fixes tektoncd#262.
@wlynch
Copy link
Member

wlynch commented Dec 11, 2019

I suspect that most users will want triggers to be in the same namespace as pipelines by default. We default to the current namespace in the EventListener if one is not explicitly provided, and that feels like behavior that makes sense.

As Dibyo pointed out, pipeline is a prerequisite for triggers - we can probably just remove the namespace config and things should just work.

@wlynch wlynch mentioned this issue Dec 11, 2019
3 tasks
wlynch added a commit to wlynch/triggers that referenced this issue Dec 12, 2019
This makes it safe to remove triggers from a cluster without impacting
the shared pipelines namespace.

Fixes tektoncd#262.
tekton-robot pushed a commit that referenced this issue Dec 12, 2019
This makes it safe to remove triggers from a cluster without impacting
the shared pipelines namespace.

Fixes #262.
savitaashture pushed a commit to savitaashture/triggers that referenced this issue Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants