Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Update docs on Exposing EL outside cluster #1217

Closed
dibyom opened this issue Sep 1, 2021 · 1 comment · Fixed by #1289
Closed

[Docs] Update docs on Exposing EL outside cluster #1217

dibyom opened this issue Sep 1, 2021 · 1 comment · Fixed by #1289
Assignees
@dibyom
Labels
kind/documentation Categorizes issue or PR as related to documentation.
Milestone
Triggers v0.18

Comments

@dibyom
Copy link
Member

dibyom commented Sep 1, 2021

The page mentions Exposing an EventListener using a Kubernetes Ingress object would not work on GKE. I think Ingress should work on GKE now.

https://github.com/tektoncd/triggers/blob/63c2ad7f7ad26f8ce9a106d76cf81068996bbf55/docs/eventlisteners.md#exposing-an-eventlistener-outside-of-the-cluster
@dibyom dibyom added the kind/documentation Categorizes issue or PR as related to documentation. label Sep 1, 2021
@dibyom dibyom self-assigned this Sep 27, 2021
@dibyom
Copy link
Member Author

dibyom commented Nov 17, 2021

We should also highlight the serviceType field with LoadBalancer as a easy way to expose the EL in hosted K8s clusters.

@dibyom dibyom added this to the Triggers v0.18 milestone Nov 17, 2021
dibyom added a commit to dibyom/triggers that referenced this issue Dec 21, 2021
@dibyom
Update docs on exposing EventListeners
36ac45c 
The section was quite a bit out of date. I added a section on `LoadBalancer`
services and removed the section on using a Nginx based ingress installed on
the cluster. The Nginx ingress was added as a workaround since early versions
of GKE did not fully support `Ingress` objects. That is now not the case and a
regular Ingress will work fine in GKE.

Fixes tektoncd#1217

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
@dibyom dibyom mentioned this issue Dec 21, 2021
Merged
4 tasks
tekton-robot pushed a commit that referenced this issue Dec 21, 2021
@dibyom @tekton-robot
Update docs on exposing EventListeners
6a40036 
The section was quite a bit out of date. I added a section on `LoadBalancer`
services and removed the section on using a Nginx based ingress installed on
the cluster. The Nginx ingress was added as a workaround since early versions
of GKE did not fully support `Ingress` objects. That is now not the case and a
regular Ingress will work fine in GKE.

Fixes #1217

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dibyom dibyom

Labels
kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
Milestone
Triggers v0.18
Development

Successfully merging a pull request may close this issue.

Update docs on exposing EventListeners dibyom/triggers
1 participant
@dibyom