Add git Resolver test using fake controller

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
tektoncd · May 24, 2022 · cb3e55e · cb3e55e
1 parent 6cc6bcd
commit cb3e55e
Show file tree

Hide file tree

Showing 5 changed files with 404 additions and 204 deletions.
diff --git a/gitresolver/pkg/git/params.go b/gitresolver/pkg/git/params.go
@@ -19,8 +19,8 @@ package git
 // URLParam is the git repo url
 const URLParam string = "url"
 
-// PathParam is the path into the git repo where a file is located
-const PathParam string = "path"
+// PathParam is the pathInRepo into the git repo where a file is located
+const PathParam string = "pathInRepo"
 
 // CommitParam is the commit hash that a file should be fetched from
 const CommitParam string = "commit"

diff --git a/gitresolver/pkg/git/resolver.go b/gitresolver/pkg/git/resolver.go
@@ -94,7 +94,7 @@ func (r *Resolver) ValidateParams(_ context.Context, params map[string]string) e
 	}
 
 	// TODO(sbwsg): validate repo url is well-formed, git:// or https://
-	// TODO(sbwsg): validate path is valid relative path
+	// TODO(sbwsg): validate pathInRepo is valid relative pathInRepo
 
 	return nil
 }