Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run pipeline's alpha tests as separate prow job #833

Merged
merged 1 commit into from May 12, 2021
Merged

Run pipeline's alpha tests as separate prow job #833

merged 1 commit into from May 12, 2021

Conversation

ghost
Copy link

@ghost ghost commented May 10, 2021

Changes

Prior to this commit the pipeline project ran two iterations of its e2e
tests as part of a single prow job: first for "stable" feature gate and then for "alpha". This doubled
the running time of the pull-tekton-pipeline-integration-tests job.

This commit adds a new job specifically for running integration tests under
"alpha" feature gate. This allows the two test runs to occur concurrently and should
hopefully reduce the iteration time on PRs. When the new alpha prow job is run
an environment variable is added which pipelines' test/e2e-tests.sh file
will recognize and use to set the feature gate.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

Prior to this commit the pipeline project ran two iterations of its e2e
tests: first for "stable" feature gate and then for "alpha". This doubles
the running time of the pull-tekton-pipeline-integration-tests job.

This commit adds a new job specifically for running integration tests under
"alpha" feature gate. This allows the jobs to run in parallel and should
hopefully reduce the iteration time on PRs. When the new alpha prow job is run
an environment variable is added which  pipelines' `test/e2e-tests.sh` file
will recognize and use to set the feature gate.
@ghost ghost added the kind/misc Categorizes issue or PR as a miscellaneuous one. label May 10, 2021
@tekton-robot tekton-robot requested review from abayer and afrittoli May 10, 2021 17:33
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 10, 2021
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2021
@vdemeester
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2021
@tekton-robot tekton-robot merged commit 9af6616 into tektoncd:main May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants