Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prow: add TEST_RUN_ALL_TESTS to catalog periodic 🖊 #621

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

vdemeester
Copy link
Member

Changes

This is to ensure we run all the tests during the nightly tests of
the catalog.

Need to be merged before tektoncd/catalog#385

Signed-off-by: Vincent Demeester vdemeest@redhat.com

/cc @afrittoli @chmouel
/kind misc

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

This is to ensure we run all the tests during the nightly tests of
the catalog.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@vdemeester vdemeester added the area/prow Issues or PRs related to prow label Oct 23, 2020
@tekton-robot tekton-robot added kind/misc Categorizes issue or PR as a miscellaneuous one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 23, 2020
@chmouel
Copy link
Member

chmouel commented Oct 23, 2020

thanks

/lgtm

Looking Good! 🤙🏽

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2020
@dibyom
Copy link
Member

dibyom commented Oct 23, 2020

/approve

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2020
@vdemeester
Copy link
Member Author

/test plumbing-golang-lint

@tekton-robot tekton-robot merged commit 955668c into tektoncd:master Oct 23, 2020
vinamra28 added a commit to vinamra28/plumbing that referenced this pull request Nov 14, 2020
In tektoncd#621 TEST_RUN_ALL_TESTS environment variable was added to tektoncd/pipeline
periodic job instead of tektoncd/catalog. This is to ensure we run
all the tests during the nightly tests of the catalog.

Signed-off-by: vinamra28 <vinjain@redhat.com>
@vinamra28 vinamra28 mentioned this pull request Nov 14, 2020
2 tasks
vinamra28 added a commit to vinamra28/plumbing that referenced this pull request Nov 14, 2020
In tektoncd#621 TEST_RUN_ALL_TESTS environment variable was added to tektoncd/pipeline
periodic job instead of tektoncd/catalog. This is to ensure we run
all the tests during the nightly tests of the catalog.

Signed-off-by: vinamra28 <vinjain@redhat.com>
tekton-robot pushed a commit that referenced this pull request Nov 16, 2020
In #621 TEST_RUN_ALL_TESTS environment variable was added to tektoncd/pipeline
periodic job instead of tektoncd/catalog. This is to ensure we run
all the tests during the nightly tests of the catalog.

Signed-off-by: vinamra28 <vinjain@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Issues or PRs related to prow kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants