Update golangci #430
Update golangci #430
Conversation
@StevenACoffman pointed out in tektoncd#241 that the 1.27 release has CPU and memory usage improvements - since we've struggled with CPU limitations in the past, and had linting timeout as a result, seems worth an upgrade!
|
This PR cannot be merged: expecting exactly one kind/ label Available
|
|
This PR cannot be merged: expecting exactly one kind/ label Available
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Seems like bumping the golangci version (tektoncd/plumbing#430) revealed some new linting issues. Pointers to items being ranged over are reused, so if this pointer is stored anywhere and used later, it can lead to bugs. I didn't see any reason why this needed to be a pointer so passing around the value instead.
Seems like bumping the golangci version (tektoncd/plumbing#430) revealed some new linting issues. Pointers to items being ranged over are reused, so if this pointer is stored anywhere and used later, it can lead to bugs. I didn't see any reason why this needed to be a pointer so passing around the value instead.
Changes
@StevenACoffman pointed out in #241
that the 1.27 release (https://github.com/golangci/golangci-lint/releases/tag/v1.27.0)
has CPU and memory usage improvements - since
we've struggled with CPU limitations in the past, and had linting
timeout as a result, seems worth an upgrade!
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.